From: Nipun Gupta <nipun.gupta@nxp.com>
To: <laurentiu.tudor@nxp.com>, <stuyoder@gmail.com>,
<bharat.bhushan@nxp.com>, <gregkh@linuxfoundation.org>,
<cakturk@gmail.com>, <bretth256@gmail.com>, <arnd@arndb.de>
Cc: <linux-kernel@vger.kernel.org>, <devel@driverdev.osuosl.org>,
Nipun Gupta <nipun.gupta@nxp.com>
Subject: [RESEND PATCH 2/2 v2] staging: fsl-mc: do not print error in case of defer probe error
Date: Mon, 11 Dec 2017 21:15:38 +0530 [thread overview]
Message-ID: <1513007138-20146-2-git-send-email-nipun.gupta@nxp.com> (raw)
In-Reply-To: <1513007138-20146-1-git-send-email-nipun.gupta@nxp.com>
Devices on MC bus can be deferred because of dependencies on other modules
(such as IOMMU). Those are not the actual errors; as probing is again
done by the kernel at later stages. So this patch avoids the error print
in such case.
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
Resending v2 as missed mentioning the changes in the version
Changes in v2:
- Added commit message
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
index 409f2b9..10cee00 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
@@ -171,7 +171,8 @@ static int fsl_mc_driver_probe(struct device *dev)
error = mc_drv->probe(mc_dev);
if (error < 0) {
- dev_err(dev, "%s failed: %d\n", __func__, error);
+ if (error != -EPROBE_DEFER)
+ dev_err(dev, "%s failed: %d\n", __func__, error);
return error;
}
--
1.9.1
next prev parent reply other threads:[~2017-12-11 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 15:45 [RESEND PATCH 1/2 v2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects Nipun Gupta
2017-12-11 15:45 ` Nipun Gupta [this message]
2017-12-12 4:55 ` Bharat Bhushan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513007138-20146-2-git-send-email-nipun.gupta@nxp.com \
--to=nipun.gupta@nxp.com \
--cc=arnd@arndb.de \
--cc=bharat.bhushan@nxp.com \
--cc=bretth256@gmail.com \
--cc=cakturk@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®