From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbdLMQCV (ORCPT ); Wed, 13 Dec 2017 11:02:21 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48463 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbdLMQCU (ORCPT ); Wed, 13 Dec 2017 11:02:20 -0500 Message-ID: <1513180898.9445.3.camel@pengutronix.de> Subject: Re: [PATCH 2/3] reset: meson-axg: add compatible string for Meson-AXG SoC From: Philipp Zabel To: Yixun Lan , Rob Herring Cc: Neil Armstrong , Jerome Brunet , Carlo Caione , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 13 Dec 2017 17:01:38 +0100 In-Reply-To: <3b61170c-c352-6b23-ab19-82c76954a911@amlogic.com> References: <20171110084650.31325-1-yixun.lan@amlogic.com> <20171110084650.31325-2-yixun.lan@amlogic.com> <3b61170c-c352-6b23-ab19-82c76954a911@amlogic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yixun, On Wed, 2017-12-13 at 22:07 +0800, Yixun Lan wrote: > Hi Philipp > > On 11/10/2017 04:46 PM, Yixun Lan wrote: > > Try to add compatible string explictly to support new Meson-AXG SoC. > > > > Signed-off-by: Yixun Lan > > --- > > drivers/reset/reset-meson.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c > > index c419a3753d00..93cbee1ae8ef 100644 > > --- a/drivers/reset/reset-meson.c > > +++ b/drivers/reset/reset-meson.c > > @@ -139,6 +139,8 @@ static const struct of_device_id meson_reset_dt_ids[] = { > > .data = &meson_reset_meson8_ops, }, > > { .compatible = "amlogic,meson-gxbb-reset", > > .data = &meson_reset_gx_ops, }, > > + { .compatible = "amlogic,meson-axg-reset", > > + .data = &meson_reset_gx_ops, }, > > { /* sentinel */ }, > > }; > > > > > > it's generally a ping to the status of these two patches[1], are they > ready to go? or do you have any comment? or do you want me to send > another version with Neil's Reviewed-by added[1] I forgot to update you on the status. I have put both patches on the reset/next branch with Neil's R-b, they are in linux-next: 0e5721f76252 ("reset: meson-axg: add compatible string for Meson-AXG SoC") c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller") I'll include them with the next pull request. regards Philipp