mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <cao.zou@windriver.com>
To: <jingoohan1@gmail.com>
Cc: <Joao.Pinto@synopsys.com>, <bhelgaas@google.com>,
	<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] PCI: designware: add a check of msi_desc in irqchip
Date: Thu, 14 Dec 2017 10:21:22 +0800	[thread overview]
Message-ID: <1513218083-5461-1-git-send-email-cao.zou@windriver.com> (raw)

----------------------------------------------------
Summary:  PCI: designware: add a check of msi_desc in irqchip
Reviewers: paul
----------------------------------------------------

Upstream Project Name: linux-kernel
Upstream Project URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
Applies to: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
Brief Description: Incorrect mask bits leave device stalled after flood ping.
Will Submit to: shan lai <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Origin of patch: Discovered by me while working on common_pc
IP content: None, trivial obvious fix.

Comments:
---------

this issue is reproduced in imx7d-sdb when running the kdump with pluging Intel 1030 PCI,
the root caused is machine_kexec_mask_interrupts will force to mask every exist irq_desc
include msi irq.

background:
msi irq mask is based on msi_desc, it is bound only in msi irq setup by pci driver.
for others not request msi irqs by pci driver, its msi_desc is null, so crash in
machine_kexec_mask_interrupts. 

             reply	other threads:[~2017-12-14  2:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14  2:21 cao.zou [this message]
2017-12-14  2:21 ` cao.zou
2017-12-15 16:17   ` Lorenzo Pieralisi
2017-12-15 17:20     ` Marc Zyngier
2017-12-18  2:02       ` Cao Zou
2017-12-18  9:32         ` Marc Zyngier
2017-12-19 16:20         ` Lorenzo Pieralisi
2017-12-22  3:04           ` Cao Zou
2017-12-22  7:38             ` Cao Zou
2017-12-22  7:39               ` Cao Zou
2017-12-22  9:35               ` Marc Zyngier
2017-12-28  2:05                 ` Cao Zou
2018-01-09 16:38                   ` Lorenzo Pieralisi
2017-12-22  9:32             ` Marc Zyngier
2017-12-22  9:40               ` Cao Zou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513218083-5461-1-git-send-email-cao.zou@windriver.com \
    --to=cao.zou@windriver.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=jingoohan1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®