From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbdLNJF0 (ORCPT ); Thu, 14 Dec 2017 04:05:26 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2289 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751027AbdLNJFX (ORCPT ); Thu, 14 Dec 2017 04:05:23 -0500 From: Li Jinyue To: , , , CC: , Li Jinyue Subject: [PATCH] futex: Prevent overflow by strengthen input validation Date: Thu, 14 Dec 2017 17:04:54 +0800 Message-ID: <1513242294-31786-1-git-send-email-lijinyue@huawei.com> X-Mailer: git-send-email 1.6.0.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.101.84] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org UBSAN reports signed integer overflow in kernel/futex.c Test log as follows: UBSAN: Undefined behaviour in kernel/futex.c:2041:18 signed integer overflow: 0 - -2147483648 cannot be represented in type 'int' To prevent overflow, we don't allow nr_wake and nr_requeue to accept a negative entropy value. Signed-off-by: Li Jinyue --- kernel/futex.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/futex.c b/kernel/futex.c index 57d0b36..0abfa09 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1878,6 +1878,9 @@ static int futex_requeue(u32 __user *uaddr1, unsigned int flags, struct futex_q *this, *next; DEFINE_WAKE_Q(wake_q); + if (nr_wake < 0 || nr_requeue < 0) + return -EINVAL; + /* * When PI not supported: return -ENOSYS if requeue_pi is true, * consequently the compiler knows requeue_pi is always false past -- 1.6.0.2