mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pravin Shedge <pravin.shedge4linux@gmail.com>
To: akpm@linux-foundation.org, fkostenzer@live.at,
	andriy.shevchenko@linux.intel.com, geert@linux-m68k.org,
	paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org
Cc: pravin.shedge4linux@gmail.com
Subject: [PATCH] lib: add module unload support to sort tests
Date: Sun, 17 Dec 2017 15:19:27 +0530	[thread overview]
Message-ID: <1513504167-4118-1-git-send-email-pravin.shedge4linux@gmail.com> (raw)

test_sort.c perform array-based and linked list sort test. Code allows to
compile either as a loadable modules or builtin into the kernel.

Current code is not allow to unload the test_sort.ko module after
successful completion.

This patch add support to unload the "test_sort.ko" module.

Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
---
 lib/test_sort.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/test_sort.c b/lib/test_sort.c
index d389c1c..26c98d0 100644
--- a/lib/test_sort.c
+++ b/lib/test_sort.c
@@ -13,11 +13,12 @@ static int __init cmpint(const void *a, const void *b)
 
 static int __init test_sort_init(void)
 {
-	int *a, i, r = 1, err = -ENOMEM;
+	int *a, i, r = 1;
+	int err = -EAGAIN; /* Fail will directly unload the module */
 
 	a = kmalloc_array(TEST_LEN, sizeof(*a), GFP_KERNEL);
 	if (!a)
-		return err;
+		return -ENOMEM;
 
 	for (i = 0; i < TEST_LEN; i++) {
 		r = (r * 725861) % 6599;
@@ -26,13 +27,12 @@ static int __init test_sort_init(void)
 
 	sort(a, TEST_LEN, sizeof(*a), cmpint, NULL);
 
-	err = -EINVAL;
 	for (i = 0; i < TEST_LEN-1; i++)
 		if (a[i] > a[i+1]) {
 			pr_err("test has failed\n");
+			err = -EINVAL;
 			goto exit;
 		}
-	err = 0;
 	pr_info("test passed\n");
 exit:
 	kfree(a);
-- 
2.7.4

             reply	other threads:[~2017-12-17  9:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-17  9:49 Pravin Shedge [this message]
2017-12-18 22:21 ` Andrew Morton
2017-12-19 17:40   ` Pravin Shedge
2017-12-19 22:51     ` Andrew Morton
2017-12-19 23:06       ` Randy Dunlap
2017-12-20  4:13     ` Paul Gortmaker
2017-12-21  2:05       ` Pravin Shedge
2017-12-22 18:25 ` [PATCH v2] " Pravin Shedge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513504167-4118-1-git-send-email-pravin.shedge4linux@gmail.com \
    --to=pravin.shedge4linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=fkostenzer@live.at \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®