From: Lucas Stach <l.stach@pengutronix.de>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
devicetree@vger.kernel.org
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: panel: Fix compatible string for Toshiba LT089AC29000
Date: Mon, 18 Dec 2017 12:53:43 +0100 [thread overview]
Message-ID: <1513598023.2890.0.camel@pengutronix.de> (raw)
In-Reply-To: <20171217023433.11542-1-j.neuschaefer@gmx.net>
Am Sonntag, den 17.12.2017, 03:34 +0100 schrieb Jonathan Neuschäfer:
> The compatible string for this panel was specified as
> toshiba,lt089ac29000.txt. I believe this is a mistake.
>
> Fixes: 06e733e41f87 ("drm/panel: simple: add Toshiba LT089AC19000")
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Yes, this is an obvious copy-and-paste issue.
Acked-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> .../devicetree/bindings/display/panel/toshiba,lt089ac29000.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt b/Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt
> index 4c0caaf246c9..89826116628c 100644
> --- a/Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt
> +++ b/Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt
> @@ -1,7 +1,7 @@
> Toshiba 8.9" WXGA (1280x768) TFT LCD panel
>
> Required properties:
> -- compatible: should be "toshiba,lt089ac29000.txt"
> +- compatible: should be "toshiba,lt089ac29000"
> - power-supply: as specified in the base binding
>
> This binding is compatible with the simple-panel binding, which is specified
next prev parent reply other threads:[~2017-12-18 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 2:34 Jonathan Neuschäfer
2017-12-18 11:53 ` Lucas Stach [this message]
2017-12-19 23:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513598023.2890.0.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®