From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937268AbdLRVjG (ORCPT ); Mon, 18 Dec 2017 16:39:06 -0500 Received: from smtprelay0237.hostedemail.com ([216.40.44.237]:34275 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936995AbdLRVjC (ORCPT ); Mon, 18 Dec 2017 16:39:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:69:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3872:4321:4605:5007:6119:7875:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12555:12740:12760:12895:13439:14181:14659:14721:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: queen27_14835e31a3a18 X-Filterd-Recvd-Size: 3105 Message-ID: <1513633139.1234.8.camel@perches.com> Subject: Re: [PATCH 2/5] staging: rtl8712: style fix multiple line dereferences From: Joe Perches To: Martin Homuth , linux-kernel@vger.kernel.org Date: Mon, 18 Dec 2017 13:38:59 -0800 In-Reply-To: References: <3cce97a4-1aeb-b663-5143-d36b3a7272fa@martinhomuth.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-12-18 at 21:36 +0100, Martin Homuth wrote: > This patch fixes various coding style issues in the rtl8712 module as > noted by checkpatch.pl related to dereferencing over multiple lines. > > It fixes the following checkpatch.pl warning: > > WARNING: Avoid multiple line dereference - prefer %s > > Signed-off-by: Martin Homuth > --- > drivers/staging/rtl8712/rtl8712_recv.c | 8 ++-- > drivers/staging/rtl8712/rtl871x_cmd.c | 36 ++++++++--------- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 58 > ++++++++++++++------------- > drivers/staging/rtl8712/rtl871x_mlme.c | 6 +-- > drivers/staging/rtl8712/rtl871x_security.c | 25 ++++++------ > 5 files changed, 69 insertions(+), 64 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c > b/drivers/staging/rtl8712/rtl8712_recv.c > index 8f555e6e1b3f..8395b90d60b6 100644 > --- a/drivers/staging/rtl8712/rtl8712_recv.c > +++ b/drivers/staging/rtl8712/rtl8712_recv.c > @@ -918,8 +918,8 @@ static void process_link_qual(struct _adapter *padapter, > } > padapter->recvpriv.signal_qual_data.total_val += > pattrib->signal_qual; > - padapter->recvpriv.signal_qual_data.elements[padapter-> > - recvpriv.signal_qual_data.index++] = probably better to use a temporary pointer for padapter->recvpriv.signal_qual_data and replace the occurrences with the temporary. s/padapter->recvpriv.signal_qual_data./sqd->/ > + padapter->recvpriv.signal_qual_data.elements > + [padapter->recvpriv.signal_qual_data.index++] = > pattrib->signal_qual; > if (padapter->recvpriv.signal_qual_data.index >= > PHY_LINKQUALITY_SLID_WIN_MAX) > @@ -947,8 +947,8 @@ static void process_rssi(struct _adapter *padapter, > union recv_frame *prframe) > } > padapter->recvpriv.signal_strength_data.total_val += > pattrib->signal_strength; > - padapter->recvpriv.signal_strength_data.elements[padapter->recvpriv. > - signal_strength_data.index++] = > + padapter->recvpriv.signal_strength_data.elements > + [padapter->recvpriv.signal_strength_data.index++] = > pattrib->signal_strength; > if (padapter->recvpriv.signal_strength_data.index >= > PHY_RSSI_SLID_WIN_MAX) and here use ssd etc.