From: Joe Perches <joe@perches.com>
To: Martin Homuth <martin@martinhomuth.de>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
becher.jannik@gmail.com, alex.mikhalevich@gmail.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 2/5] staging: rtl8712: style fix multiple line dereferences
Date: Mon, 18 Dec 2017 18:50:17 -0800 [thread overview]
Message-ID: <1513651817.1234.14.camel@perches.com> (raw)
In-Reply-To: <20171218231847.26230-3-martin@martinhomuth.de>
On Tue, 2017-12-19 at 00:18 +0100, Martin Homuth wrote:
> This patch fixes various coding style issues in the rtl8712 module as
> noted by checkpatch.pl related to dereferencing over multiple lines.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
[]
> @@ -899,6 +899,7 @@ static void process_link_qual(struct _adapter *padapter,
> {
> u32 last_evm = 0, tmpVal;
> struct rx_pkt_attrib *pattrib;
> + struct smooth_rssi_data *sqd = &padapter->recvpriv.signal_qual_data;
>
> if (prframe == NULL || padapter == NULL)
> return;
> @@ -918,9 +919,8 @@ static void process_link_qual(struct _adapter *padapter,
> }
> padapter->recvpriv.signal_qual_data.total_val +=
> pattrib->signal_qual;
> - padapter->recvpriv.signal_qual_data.elements[padapter->
> - recvpriv.signal_qual_data.index++] =
> - pattrib->signal_qual;
> + padapter->recvpriv.signal_qual_data.elements[sqd->index++] =
> + pattrib->signal_qual;
This should now become
sqd->elements[sqd->index++] = pattrib->signal_qual;
prev parent reply other threads:[~2017-12-19 2:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 23:18 [PATCH v2 0/5] staging: rtl8712: fix several checkpatch style issues Martin Homuth
2017-12-18 23:18 ` [PATCH v2 1/5] staging: rtl8712: style fix over 80 characters warnings Martin Homuth
2017-12-18 23:18 ` [PATCH v2 2/5] staging: rtl8712: style fix multiple line dereferences Martin Homuth
2017-12-19 2:50 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513651817.1234.14.camel@perches.com \
--to=joe@perches.com \
--cc=alex.mikhalevich@gmail.com \
--cc=becher.jannik@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@martinhomuth.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®