From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752773AbdLSQmF (ORCPT ); Tue, 19 Dec 2017 11:42:05 -0500 Received: from smtprelay0034.hostedemail.com ([216.40.44.34]:55703 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbdLSQmC (ORCPT ); Tue, 19 Dec 2017 11:42:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3873:4321:5007:6119:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: cook47_68b31f82d1b61 X-Filterd-Recvd-Size: 2252 Message-ID: <1513701718.1234.47.camel@perches.com> Subject: Re: [PATCH v3 2/5] staging: rtl8712: style fix multiple line dereferences From: Joe Perches To: Martin Homuth , alex.mikhalevich@gmail.com, rvarsha016@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Date: Tue, 19 Dec 2017 08:41:58 -0800 In-Reply-To: <20171219163216.9793-3-martin@martinhomuth.de> References: <20171219163216.9793-1-martin@martinhomuth.de> <20171219163216.9793-3-martin@martinhomuth.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-12-19 at 17:32 +0100, Martin Homuth wrote: > This patch fixes various coding style issues in the rtl8712 module as > noted by checkpatch.pl related to dereferencing over multiple lines. [] > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c [] > @@ -899,6 +899,7 @@ static void process_link_qual(struct _adapter *padapter, > { > u32 last_evm = 0, tmpVal; > struct rx_pkt_attrib *pattrib; > + struct smooth_rssi_data *sqd = &padapter->recvpriv.signal_qual_data; > > if (prframe == NULL || padapter == NULL) > return; > @@ -918,9 +919,7 @@ static void process_link_qual(struct _adapter *padapter, > } > padapter->recvpriv.signal_qual_data.total_val += > pattrib->signal_qual; You missed more than one substitution. sqd->total_val += pattrib->signal_qual; > - padapter->recvpriv.signal_qual_data.elements[padapter-> > - recvpriv.signal_qual_data.index++] = > - pattrib->signal_qual; > + sqd->elements[sqd->index++] = pattrib->signal_qual; > if (padapter->recvpriv.signal_qual_data.index >= > PHY_LINKQUALITY_SLID_WIN_MAX) > padapter->recvpriv.signal_qual_data.index = 0; And here too sqd->index = 0; Dunno if there are more, but if you are modifying the function, you should do the appropriate function local sed.