From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756687AbdLTXaE (ORCPT ); Wed, 20 Dec 2017 18:30:04 -0500 Received: from mga07.intel.com ([134.134.136.100]:40057 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756322AbdLTXaA (ORCPT ); Wed, 20 Dec 2017 18:30:00 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,434,1508828400"; d="scan'208";a="4363261" From: Megha Dey To: linux-kernel@vger.kernel.org Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, yu-cheng.yu@intel.com, megha.dey@intel.com, Megha Dey Subject: [PATCH V1] perf tools: Get correct max value of format attribute Date: Wed, 20 Dec 2017 15:46:23 -0800 Message-Id: <1513813583-13847-1-git-send-email-megha.dey@linux.intel.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, the maximum value of every format attribute is not being correctly set. For eg: cat /sys/devices/cpu/format/umask config:8-15 This implies the max_value of umask should be 0xff ./perf stat –e cpu/umask=0x100/ sleep 1 Performance counter stats for '../rets-128.bin': 0 cpu/umask=0x100/ 0.109157272 seconds time elapsed works just fine(0x100 > 0xff). Whereas, ./perf stat –e cpu/umask=0xff01/ sleep 1 event syntax error: 'cpu/umask=0xff01/' \___ value too big for format, maximum is 65280(0xff00) The maximum value is set to 0xff00 instead of 0xff. This patch fixes the pmu_format_max_value() function to return the correct maximum value. Acked-by: Jiri Olsa Signed-off-by: Megha Dey --- tools/perf/util/pmu.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 2fffc3a..2bf7a7d 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -777,13 +777,7 @@ static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, static __u64 pmu_format_max_value(const unsigned long *format) { - __u64 w = 0; - int fbit; - - for_each_set_bit(fbit, format, PERF_PMU_FORMAT_BITS) - w |= (1ULL << fbit); - - return w; + return (1ULL << bitmap_weight(format, PERF_PMU_FORMAT_BITS)) - 1; } /* -- 1.9.1