mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: venkataravi.e@techveda.org
To: gregkh@linuxfoundation.org
Cc: christian.gromm@microchip.com, steve.knipe@gmail.com,
	gustavo@embeddedor.com, andrey.shvetsov@k2l.de,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	sunil.m@techveda.org, shrikant.maurya@techveda.org,
	Ravi Eluri <venkataravi.e@techveda.org>
Subject: [PATCH] staging: most: Fix identifiers to function parameters
Date: Fri, 22 Dec 2017 15:39:02 +0530	[thread overview]
Message-ID: <1513937342-9571-1-git-send-email-venkataravi.e@techveda.org> (raw)

From: Ravi Eluri <venkataravi.e@techveda.org>

fixed "function definition argument should have an identifier name",
with appropriate identifier names. Pointed out by checkpatch.

Signed-off-by: Ravi Eluri <venkataravi.e@techveda.org>
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
Note:
- This is the first patch of the two patch series.
- Patch was compile tested and built(ARCH=arm) on linux-next
  (latest).
- No build/run-time issues reported.
---
 drivers/staging/most/dim2/dim2.c | 4 ++--
 drivers/staging/most/usb/usb.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index 2bd40ab..21e3fb4 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -101,8 +101,8 @@ struct dim2_hdm {
 	unsigned char link_state;
 	int atx_idx;
 	struct medialb_bus bus;
-	void (*on_netinfo)(struct most_interface *,
-			   unsigned char, unsigned char *);
+	void (*on_netinfo)(struct most_interface *most_iface,
+			   unsigned char link_state, unsigned char *addrs);
 };
 
 #define iface_to_hdm(iface) container_of(iface, struct dim2_hdm, most_iface)
diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c
index 8d23075..31f184c 100644
--- a/drivers/staging/most/usb/usb.c
+++ b/drivers/staging/most/usb/usb.c
@@ -117,8 +117,8 @@ struct most_dev {
 	struct mutex io_mutex;
 	struct timer_list link_stat_timer;
 	struct work_struct poll_work_obj;
-	void (*on_netinfo)(struct most_interface *, unsigned char,
-			   unsigned char *);
+	void (*on_netinfo)(struct most_interface *most_iface,
+			   unsigned char link_state, unsigned char *addrs);
 };
 
 #define to_mdev(d) container_of(d, struct most_dev, iface)
-- 
1.9.1

                 reply	other threads:[~2017-12-22 10:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513937342-9571-1-git-send-email-venkataravi.e@techveda.org \
    --to=venkataravi.e@techveda.org \
    --cc=andrey.shvetsov@k2l.de \
    --cc=christian.gromm@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shrikant.maurya@techveda.org \
    --cc=steve.knipe@gmail.com \
    --cc=sunil.m@techveda.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®