From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbaERX7A (ORCPT ); Sun, 18 May 2014 19:59:00 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:64356 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752262AbaERX67 (ORCPT ); Sun, 18 May 2014 19:58:59 -0400 From: "Rafael J. Wysocki" To: Mike Turquette Cc: Heikki Krogerus , Mika Westerberg , Jin Yao , Li Aubrey , Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 3/4] clk: new basic clk type for fractional divider Date: Mon, 19 May 2014 02:15:52 +0200 Message-ID: <1514106.ndh3ZJ8v0Y@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20140517013403.9521.86191@quantum> References: <1400161226-24067-1-git-send-email-heikki.krogerus@linux.intel.com> <3823442.HzUarSqr07@vostro.rjw.lan> <20140517013403.9521.86191@quantum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, May 16, 2014 06:34:03 PM Mike Turquette wrote: > Quoting Rafael J. Wysocki (2014-05-16 17:15:43) > > On Friday, May 16, 2014 04:09:05 PM Mike Turquette wrote: > > > Quoting Rafael J. Wysocki (2014-05-16 15:38:05) > > > > On Thursday, May 15, 2014 09:53:49 AM Mike Turquette wrote: > > > > > Quoting Heikki Krogerus (2014-05-15 06:40:25) > > > > > > Fractional divider clocks are fairly common. This adds basic > > > > > > type for them. > > > > > > > > > > > > Signed-off-by: Heikki Krogerus > > > > > > > > > > Taken into clk-next. > > > > > > > > > > Just FYI, there was some talk at Embedded Linux Conference on providing > > > > > a better abstraction layer for some of these "basic" clock types. This > > > > > abstraction would allow the basic clock types to implement the > > > > > machine-agnostic logic (e.g. an incoming rate is divided by a value) and > > > > > then platforms and drivers could plug in the machine-specific parts > > > > > (e.g. divider is made up of m/n, or divider is power-of-two, or divider > > > > > is a simple integer with min == 1 and max == 5). > > > > > > > > > > All of that is to say that in time this fractional divider could go away > > > > > once the abstraction layer allows us to fold the m/n divider stuff into > > > > > a core divider implementation. > > > > > > > > > > Nothing wrong with the patch for now, so I've taken it for 3.16. > > > > > > > > Well, OK, but I guess [4/4] depends on it and [4/4] also depends on > > > > [1-2/4], so how you're proposing to resolve this? > > > > > > I haven't yet published this patch to my tree, so no harm done. How > > > about the following Formal Proposals? > > > > > > 1) I ack the patch and don't merge it through my tree. You take it. > > > 2) I provide a topic branch that we both merge. > > > > > > Your choice. > > > > Thanks! I'd prefer 1) to be honest. :-) > > Acked-by: Mike Turquette Thanks!