From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: gregkh@linuxfoundation.org, christophe.jaillet@wanadoo.fr,
singhalsimran0@gmail.com, szekelyszilv@gmail.com,
gs051095@gmail.com, elia.f.geretto@gmail.com, robsonde@gmail.com,
shreeya.patel23498@gmail.com, keescook@chromium.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [PATCH] staging: rtl8192u: Replace mdelay with msleep in rtl8192_usb_probe
Date: Sun, 24 Dec 2017 18:16:55 +0800 [thread overview]
Message-ID: <1514110615-20342-1-git-send-email-baijiaju1990@gmail.com> (raw)
rtl8192_usb_probe is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with msleep,
to avoid busy wait.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 09f66b3..3c300f7 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -4998,7 +4998,7 @@ static int rtl8192_usb_probe(struct usb_interface *intf,
kfree(priv->pFirmware);
priv->pFirmware = NULL;
rtl8192_usb_deleteendpoints(dev);
- mdelay(10);
+ msleep(10);
free_ieee80211(dev);
RT_TRACE(COMP_ERR, "wlan driver load failed\n");
--
1.7.9.5
next reply other threads:[~2017-12-24 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 10:16 Jia-Ju Bai [this message]
2017-12-30 11:07 Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514110615-20342-1-git-send-email-baijiaju1990@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devel@driverdev.osuosl.org \
--cc=elia.f.geretto@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gs051095@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robsonde@gmail.com \
--cc=shreeya.patel23498@gmail.com \
--cc=singhalsimran0@gmail.com \
--cc=szekelyszilv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®