From: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
To: <dan.j.williams@intel.com>, <vinod.koul@intel.com>,
<michal.simek@xilinx.com>, <appanad@xilinx.com>,
<lars@metafoo.de>, <akinobu.mita@gmail.com>,
<joabreu@synopsys.com>, <mike.looijmans@topic.nl>,
<kedare06@gmail.com>
Cc: <dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 3/4] dmaengine: xilinx_dma: Fix warning variable prev set but not used
Date: Wed, 3 Jan 2018 12:12:10 +0530 [thread overview]
Message-ID: <1514961731-1916-4-git-send-email-appanad@xilinx.com> (raw)
In-Reply-To: <1514961731-1916-1-git-send-email-appanad@xilinx.com>
This patch fixes the below sparse warning in the driver
drivers/dma/xilinx/xilinx_dma.c: In function ‘xilinx_vdma_dma_prep_interleaved’:
drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
struct xilinx_vdma_tx_segment *segment, *prev = NULL;
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
Changes for v2:
--> Improved commit message title and description
as suggested by Vinod.
drivers/dma/xilinx/xilinx_dma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 8467671..845e638 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
{
struct xilinx_dma_chan *chan = to_xilinx_chan(dchan);
struct xilinx_dma_tx_descriptor *desc;
- struct xilinx_vdma_tx_segment *segment, *prev = NULL;
+ struct xilinx_vdma_tx_segment *segment;
struct xilinx_vdma_desc_hw *hw;
if (!is_slave_direction(xt->dir))
@@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan,
/* Insert the segment into the descriptor segments list. */
list_add_tail(&segment->node, &desc->segments);
- prev = segment;
-
/* Link the last hardware descriptor with the first. */
segment = list_first_entry(&desc->segments,
struct xilinx_vdma_tx_segment, node);
--
2.7.4
next prev parent reply other threads:[~2018-01-03 6:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 6:42 [PATCH v2 0/4] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2018-01-03 6:42 ` [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly Kedareswara rao Appana
2018-01-08 10:38 ` Vinod Koul
2018-01-08 10:52 ` Appana Durga Kedareswara Rao
2018-01-08 17:06 ` Vinod Koul
2018-01-08 17:25 ` Appana Durga Kedareswara Rao
2018-01-09 4:48 ` Vinod Koul
2018-01-09 4:48 ` Appana Durga Kedareswara Rao
2018-01-09 5:04 ` Vinod Koul
2018-01-09 7:36 ` Appana Durga Kedareswara Rao
2018-01-11 6:21 ` Vinod Koul
2018-01-03 6:42 ` [PATCH v2 2/4] dmaengine: xilinx_dma: properly configure the SG mode bit in the driver for cdma Kedareswara rao Appana
2018-01-08 10:55 ` Vinod Koul
2018-01-03 6:42 ` Kedareswara rao Appana [this message]
2018-01-03 6:42 ` [PATCH v2 4/4] dmaengine: xilinx_dma: Free BD consistent memory Kedareswara rao Appana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514961731-1916-4-git-send-email-appanad@xilinx.com \
--to=appana.durga.rao@xilinx.com \
--cc=akinobu.mita@gmail.com \
--cc=appanad@xilinx.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=kedare06@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mike.looijmans@topic.nl \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®