mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	konrad.wilk@oracle.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] swiotlb: suppress warning when __GFP_NOWARN is set v3
Date: Wed, 03 Jan 2018 07:01:35 -0800	[thread overview]
Message-ID: <1514991695.31497.12.camel@perches.com> (raw)
In-Reply-To: <20180103100955.17182-1-christian.koenig@amd.com>

On Wed, 2018-01-03 at 11:09 +0100, Christian König wrote:
> TTM tries to allocate coherent memory in chunks of 2MB first to improve
> TLB efficiency and falls back to allocating 4K pages if that fails.
> 
> Suppress the warning when the 2MB allocations fails since there is a
> valid fall back path.
[]
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
[]
> @@ -490,11 +490,11 @@ static void swiotlb_bounce(phys_addr_t orig_addr, phys_addr_t tlb_addr,
>  	}
>  }
>  
> -phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
> -				   dma_addr_t tbl_dma_addr,
> -				   phys_addr_t orig_addr, size_t size,
> -				   enum dma_data_direction dir,
> -				   unsigned long attrs)
> +phys_addr_t tbl_map_single(struct device *hwdev,
> +			   dma_addr_t tbl_dma_addr,
> +			   phys_addr_t orig_addr, size_t size,
> +			   enum dma_data_direction dir,
> +			   unsigned long attrs, bool warn)

shouldn't this be static?

      reply	other threads:[~2018-01-03 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 10:09 Christian König
2018-01-03 15:01 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514991695.31497.12.camel@perches.com \
    --to=joe@perches.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome