From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935250AbeAHQtz (ORCPT + 1 other); Mon, 8 Jan 2018 11:49:55 -0500 Received: from mga09.intel.com ([134.134.136.24]:47838 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935149AbeAHQsh (ORCPT ); Mon, 8 Jan 2018 11:48:37 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="18423263" From: Vinod Koul To: Greg KH Cc: LKML , Sanyog Kale , Colin Ian King Subject: [PATCH 2/3] soundwire: intel: fix missing assignment to ret Date: Mon, 8 Jan 2018 22:22:43 +0530 Message-Id: <1515430364-12079-2-git-send-email-vinod.koul@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515430364-12079-1-git-send-email-vinod.koul@intel.com> References: <1515430364-12079-1-git-send-email-vinod.koul@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Colin Ian King Currently the return status ret is being checked but it has not been updated since the previous check on ret. It appears that assignment of ret from return status of the call to sdw_cdns_enable_interrupt was accidentally ommited. Fix this. Detected by CoverityScan, CID#1463148 ("Logically dead code") Fixes: 71bb8a1b059e ("soundwire: intel: Add Intel Master driver") Signed-off-by: Colin Ian King Acked-by: Vinod Koul --- drivers/soundwire/intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 6a9177ea6eb9..86a7bd1fc912 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -295,7 +295,7 @@ static int intel_probe(struct platform_device *pdev) if (ret) goto err_init; - sdw_cdns_enable_interrupt(&sdw->cdns); + ret = sdw_cdns_enable_interrupt(&sdw->cdns); if (ret) goto err_init; -- 2.7.4