From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbeAJUq4 (ORCPT + 1 other); Wed, 10 Jan 2018 15:46:56 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:44669 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbeAJUqy (ORCPT ); Wed, 10 Jan 2018 15:46:54 -0500 X-Google-Smtp-Source: ACJfBos55ioBkIRVnR7NZeHM7G2qqzTlQNYNzkR0VCNyxASVbWjDbTvPPI/9ZFNA/ifhRN5Cq4CYeA== From: Mathieu Poirier To: acme@kernel.org, ak@linux.intel.com Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG Date: Wed, 10 Jan 2018 13:46:51 -0700 Message-Id: <1515617211-32024-1-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit ("d0565132605f perf evsel: Enable type checking for perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG isn't used and as such adds a BUG_ON(). Since the enumeration type is used in macro ADD_CONFIG_TERM() the change break CoreSight trace acquisition. This patch restores the original code. Signed-off-by: Mathieu Poirier --- tools/perf/util/evsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index a4d256ea0dc4..b22071a20cd1 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -781,7 +781,7 @@ static void apply_config_terms(struct perf_evsel *evsel, attr->write_backward = term->val.overwrite ? 1 : 0; break; case PERF_EVSEL__CONFIG_TERM_DRV_CFG: - BUG_ON(1); + break; default: break; } -- 2.7.4