From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: acme@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, yao.jin@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] perf util: Do not reuse target->per_thread flag
Date: Fri, 12 Jan 2018 16:12:22 -0700 [thread overview]
Message-ID: <1515798743-2541-1-git-send-email-mathieu.poirier@linaro.org> (raw)
Hi Arnaldo,
Here is another stab at addressing the side effect introduced by commit
("73c0ca1eee3d perf thread_map: Enumerate all threads from /proc").
I have decided to add another variable to struct target, which keep
things simple and doesn't touch the core. Another solution could have
been to make target->per_thread an enumaration with values PER_THREAD
and ALL_THREAD, something that could be switched on in function
thread_map__new_str().
I opted for the first option as it makes the code easier to understand.
Let me know what you prefer or get back to me with a better solution if
you see one.
Thanks,
Mathieu
Mathieu Poirier (1):
perf util: Do not reuse target->per_thread flag
tools/perf/builtin-stat.c | 2 +-
tools/perf/util/evlist.c | 2 +-
tools/perf/util/target.h | 1 +
tools/perf/util/thread_map.c | 4 ++--
tools/perf/util/thread_map.h | 2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
--
2.7.4
next reply other threads:[~2018-01-12 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 23:12 Mathieu Poirier [this message]
2018-01-12 23:12 ` [PATCH 1/1] " Mathieu Poirier
2018-01-22 13:05 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515798743-2541-1-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®