From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbeAQMje (ORCPT + 1 other); Wed, 17 Jan 2018 07:39:34 -0500 Received: from mail-eopbgr60138.outbound.protection.outlook.com ([40.107.6.138]:13696 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752749AbeAQMjb (ORCPT ); Wed, 17 Jan 2018 07:39:31 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ktkhai@virtuozzo.com; Subject: [PATCH v2 0/3] tty: Make __do_SAK() less greedy in regard to tasklist_lock From: Kirill Tkhai To: gregkh@linuxfoundation.org, jslaby@suse.com, oleg@redhat.com, ebiederm@xmission.com, ktkhai@virtuozzo.com Cc: linux-kernel@vger.kernel.org Date: Wed, 17 Jan 2018 15:39:24 +0300 Message-ID: <151619233415.5683.18062849657787533510.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR09CA0049.eurprd09.prod.outlook.com (2603:10a6:7:3c::17) To VI1PR0801MB1342.eurprd08.prod.outlook.com (2603:10a6:800:3a::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e5d83d8e-8702-4240-40ef-08d55da758c2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:VI1PR0801MB1342; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1342;3:Rk8MNOoXG4/+t1PL0QTXTcbbyPXSTIVQxHEPMlCgZ8EoXGcWFZPsEAldnupmBX7Fqa1JfSfUcqF5BOpzsZy7bCcXFj30TyUeg9QLW/bCJ8SoNYTA2lVIKs6aDV0MGKKOtoG48dkPHqMA8xcAID7V6tcMZRHoM0i/hxkXtn/V016ewy4VUWvQpZGnnZGxIiWfRGu+7Z0dbEWjfRiN0A9po3P6+xv7sIeIyzWDvhtL/KuZtHWq+nAXe+MfXsQkKIW0;25:Hce2EUEvRgD1oAgoG+w7P/GSoYqshgrKMt3j96OKiZZvN8pKQ3bAI4+afbDAz3dNlnOlJ3tDKUlEK+KJ4iyGTVQTG3DZxo7LvWAjCUS5ODlYWs1lbTR0oTDkNpm4Xy10QNop9noNBqTLBks/4gNqN75xZG2s9y0UUSyrDJoXNmX/hJxEEnWjvw3oDL14mfLe1kTG5v6dVDe+G2RInCxseztyIg9vLWXtLhvf4wPsU6nnzp9d8AsP6z1IiYQOdXiAfT3aCs4JipLttAQVuDMzvif0C/fmQvCOpDVWw1wHZlZTjQetOTBSF3lC4Qsr5ujjlLM5wE2l1RIqHVgtLWMaig==;31:FSpPVkN7H2g/7r7IO8FtHdYNEvjonug8NxLWDmkJVN56TSLo/Rp+XRjY7T193XuBK/TksIKMxYjhC5xiBkexaZOQ8HMopWemGag320SfLFDT5NRuNYdvz0zfj77066sWeFSOYSNybiReVk1+EKUXVuwzl8vVfG4mpNHQA1CnKr2Mu4SvV8aKWf8lclZjSEmNmpJT3e1yEkdwNdfKNCk95D9vGSFE6zMEWl1NnASarmo= X-MS-TrafficTypeDiagnostic: VI1PR0801MB1342: X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1342;20:Cu2HALo/gQN/VCZOfh5CHWu7W9QutcIwabEb9dMTnxS3zDRFXuN2tmZrJTVsSdiQujgos6QvKSUb+PqVz/rowmxwRr5yYToG12a72H0JVjRAke9wv1PL1g26msz6cTJp0pLyo4YKkp2OWzQtv4vmwTAlJAPB+/Hv+jMyyFMbpFZAiMdI1vtVRhFkKaL5fQd0UcVmfKHSYBVs29O7ww8OClLjdzXs5ykWdavHcEex9UnJqLoqkAcC8/DsLW7h1w2NSwZQcq9qzqDD2MRoLEgK2mhZ3BSo9PotnezJM/gjQTUDQSuU+1NTARrzx7uIcegDhgUQAeAJqTlXuS+IMUhzyb+Xb4MGCF9yy748L9m8SfMgT1qvWNagpnD8l76gZqgyegbV4cWyLqSqwwxv/upon8DDKSxSnMUpvEO02/Yg5Cs=;4:vIcMSqJlu3SNR4fBiSdtPyqw5Pmqhg3io5sDUwTpKaty3W8QhsYxD5/x4LgGF6MwzWv/EKVEsElsJ2cXp2CkSPk84UjBLvGa3SX8khiDrXbdIFadFYWv9y53k6abtkT0h4k91+iCkNnNegL201L/B0X8v52Vhsaq0BPM0FIQNfnRXVt+NMwD8Q043UKhGSpPqPxaacBhSB4Bei4ab4YaNdRluIVliJb3wDMU8mKRYJGIMw8Eer/Tmkpzga1fAI8o119qi7pxFWeHNlYph/dznA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(944501161)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011);SRVR:VI1PR0801MB1342;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0801MB1342; X-Forefront-PRVS: 0555EC8317 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6069001)(396003)(39850400004)(366004)(39380400002)(376002)(346002)(199004)(189003)(50466002)(2906002)(55016002)(6306002)(47776003)(52116002)(7696005)(23676004)(966005)(478600001)(106356001)(230700001)(16526018)(6116002)(2486003)(3846002)(103116003)(33896004)(386003)(316002)(83506002)(6506007)(59450400001)(58126008)(105586002)(68736007)(53936002)(7736002)(81166006)(8676002)(81156014)(5660300001)(305945005)(8936002)(9686003)(25786009)(66066001)(61506002)(26005)(97736004)(86362001)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1342;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4MDFNQjEzNDI7MjM6Ly9WaVZtc1hsV3Z1TCtjbUhqaXh0QndC?= =?utf-8?B?Qy9FY0NZTEdXQzlVVnJ5UCtIOW9GMVN6RWtWM1lWK3kxNUlsU3QvVW8zZVR2?= =?utf-8?B?V2xrdkMwc2F2R3d2Q3BwTnhQQ0ZkSTRDZEZ1NW9pU0lGUGtPYWt3ejBDS0RM?= =?utf-8?B?b2cvcXVrMSsvMmc0TFl3ME43OTlmL3h4dFNSU21pL25zcGlOdGwzVzNQSkxi?= =?utf-8?B?UW4weDFWYTVGNytoQnYzbGZlTkJydndXaVpaSnRoVjcrNHZOVVVnWUlDWEhk?= =?utf-8?B?eEZnY3lEdE5mNEZ1U2hSUFhuTWdBbVBLSlNWSThFaEcwNFQrSC8rVmVqQ1NB?= =?utf-8?B?SFBBcE9ad01NaytDUTR0VUJ4R2dCK0FXc01URFFnTzdUM1dtM0xUdm9hRlRj?= =?utf-8?B?UEUrelhTOUk2aEhvY0Y2WW9TWE1waDJiNkdwNG9xSlFMcjE1d2RrS1dpeEN2?= =?utf-8?B?QzZvanpTUVhCRTc1UGRENCszc2tBdGlKRC9xVVZZa3lTZVRjbERHYXZNNk91?= =?utf-8?B?NCttcWxIeVhFOXJYa2xKejk3MzhPd1JWYkducnJkTUNNR3JJS2NXMHk0Qms3?= =?utf-8?B?cW1VTTg4eUxIblpCdlZmTmV6dzBFWE00cmpaV09SNVhOaWY4WnlGRERGcWYv?= =?utf-8?B?TlMvN05oZlY0RW92cTJ5TjBwRmJlejBwT0U1cnFvc1l0N3E2QVdHT3hSVHhQ?= =?utf-8?B?TTFtMHUwU2hVeUJYbHVqY29ocVdLVkVDYmxZNDJ6a1ZYc1Q1YlRNKzhnTHVn?= =?utf-8?B?Q0xMVlR1VklucGJycTRMNFU1NUNWaitNZENDTXRwZ3FZVUJuQnVxWU9hYjR6?= =?utf-8?B?WkJROEYyWERjRExITngwQnZIdnVmUTJXN0FrYS9reEpiSU9sdnhCc3NXYVNQ?= =?utf-8?B?VmhqR3B4L0hWS2EwRHdaZVJZVkJ4c2QrQlRId1pwbFJWRE9FQTl1bTNTSTlX?= =?utf-8?B?SytJaS9NY3Z6WlNFWUdTeHZFNm1COGNHR0l2S01uelVHa2txN3Fsc3BsQkxY?= =?utf-8?B?NGFZcThJWVVKZHpiT0dZdjFRblZmR09JRnFaSWg3TVEwekV1S1QrQy9Id0du?= =?utf-8?B?MmZvNmNnTlAvekh0bVlyd090RHhpNytQTVNqRjMrVWc0T3JjZzg5NFROZ3Zl?= =?utf-8?B?VDgrclVvazAzb0tpTmpxSjZ1blFrdlBNWXROY1NNRTJ5M09TUXo1UFpnL3U0?= =?utf-8?B?TEp2Zk9HMWFBWUtTd3FRRHVRSmxNcTRSbWNlcFluWmpSWFFmNU5qOGZrMS8z?= =?utf-8?B?K2h2RzhoY0o1K2ExTFN2NGZDZGFSQlJBSDJ0K05ld29uMWczcDh4VGFUblpq?= =?utf-8?B?azBhcVpJUWdpSFhaTG96dnpsUjluTlR5amlWaUc1NmEvdGhOVUtMODJwT3RF?= =?utf-8?B?OXR4Z09mQ2NGRTJnUUxJZmhwYXVaNWZBcjJJMTV1c1lWRGdVTlM4QndtN2dD?= =?utf-8?B?cjY0VldBVWpQbkR2ZVg5Z0Q4TDIzdHlaOFVST0Y3S3liYm9lTFlRMUU3WVNR?= =?utf-8?B?dHI1d3ViSzRKRDhHL0N0ZGVRZGgxZHFCWENXOWlPb0h5RkJFZytQdTJIVW5F?= =?utf-8?B?OGlQUUN3T3k2TW1HcDIxK3BCa0lkdUhLQT09?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1342;6:7IV0oHKktzK1B9Vx0/5Lb82UF0ERf+DFclajac8yBYCaq5AFBIVNTR9Y0H8XmwkDoVlcbPgSPFdgTwbykfUijAEV74/NxYPO9UuFMgpAIIT8YJwRNltG/PY1KNQZVUg87hd+MWzpeuAlWme7eHAbcEUoP0+9c4XNSMlNpA5K9eHGFsPrFDZY76q62TYlFkYx60G2GcV/n6NvisJ/31/w8nf+U069jhXeCmaJoYimxlGCVN3mwc03fpwpMS+OE+v7ib38TyKFUvHjGx6pTGRM2r9TUIXpNBPozNSSd1IPD9EZNsZxUaUoJzPC+kafd70Gmr33UmGgFCVOzn66dyUu9mRYSGbShsxwdZ0T1i99gqE=;5:7X7mdfFsmdYcGN76hotsGQkYiL/pi7jzK5nlwx9Z38A25VO8iDp36xa1UGc3K20vCOA+zk78xMczXd678TSmQYkX9parJb60yNMcLBgcX7ERCEwwCeoIVnZ9yu0JdN3x0ZyZVRe4kHDaXgSVkB2o3sNvfvefH4SPtve0Ew3YrWs=;24:kyvJOjhW5ILEirVOs3mCCTGPb8w0mKNHJF939F+YNP6mq2kpy0UwZSOl7vvDxu6M+80xLN3t0leiv9c9Ss0PszCZ/kQ3loVLpUkAKFeoXHc=;7:kp+FSVwSt9ZWeVen987KYWMGbS4bjuYSzEdHjmhNRPKYyVeHkXXWL2C+oSa4w7DbXIxV+iOGdf0n5VSScndmmfDShcIbN8hA0UH0uaISUfmYWIqgv0dj0V2u58a4Bp8fAcrRW4utSVUBkRiuQFQqsUiwsjUJfYWSQlW2O7DZbURZkY/96BBD6Xo9xl43t/dY9MoaLnbRhYRLRFylgga+nwtB+2+jD4L4vHn+SPq+BuY6xVSr081hHiK+GVylqGyy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1342;20:R8LAjeIp0wwCV4kUjepjL3z7yQKkZaPT6G04TTEMpgzW69VhL6aqvr2Zh8uTjMeY02l3UUlxjLgV+CAzntc3j+t6xszEcENpQDmV25FfJ1r1ixpDYXzAAatf2GY/5R8TOeigIGmZxKMvlT3VD4fmVCmxPrHU1o2eciw7kfr5Zss= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2018 12:39:26.7215 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5d83d8e-8702-4240-40ef-08d55da758c2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1342 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi, this patchset makes __do_SAK() to take tasklist_lock for very small time in comparison to that it does now. Though this function is executed in process context and it takes tasklist_lock read locked with interrupts enabled, another tasks may want to take it for writing with interrupt disabled (e.g., forking tasks), and these tasks may evoke hard lockups. I've observed several hard lockups caused by long execution of __do_SAK() on the node with 200 big containers. 3.10 kernel is used there, and mainline kernel does not have differences in comparation to that, because of __do_SAK() function has not changed for a long time. So, mainline kernel has this problem too. The patchset proposes two optimizations in __do__SAK(). The first one is to skip threads, when they share previous thread's fd table [2/3]. The second optimization is to iterate task list under rcu_read_lock(). This allows to take tasklist_lock for a very small time just to check we reached the end of the task list. See patch [3/3] for the details. v2: All three patches changed. Now we don't care about races with unshare_files() and do not take tasklist_lock on reaching task list end. Link to v1: https://lkml.org/lkml/2018/1/11/486 Thanks, Kirill --- Kirill Tkhai (2): Revert "do_SAK: Don't recursively take the tasklist_lock" tty: Use RCU read lock to iterate tasks and threads in __do_SAK() Oleg Nesterov (1): tty: Avoid threads files iterations in __do_SAK() drivers/tty/tty_io.c | 41 ++++++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 13 deletions(-) -- Signed-off-by: Kirill Tkhai