From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbeARBxb convert rfc822-to-8bit (ORCPT ); Wed, 17 Jan 2018 20:53:31 -0500 Received: from mx01.hxt-semitech.com.96.203.223.in-addr.arpa ([223.203.96.7]:50040 "EHLO barracuda.hxt-semitech.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752368AbeARBx3 (ORCPT ); Wed, 17 Jan 2018 20:53:29 -0500 X-ASG-Debug-ID: 1516240405-093b7e0d773fef0001-xx1T2L X-Barracuda-Envelope-From: shunyong.yang@hxt-semitech.com From: "Yang, Shunyong" To: "tglx@linutronix.de" , "marc.zyngier@arm.com" CC: "linux-kernel@vger.kernel.org" , "Zheng, Joey" Subject: Re: [PATCH] irqdomain: provide useful debugging information for irq domain Thread-Topic: [PATCH] irqdomain: provide useful debugging information for irq domain X-ASG-Orig-Subj: Re: [PATCH] irqdomain: provide useful debugging information for irq domain Thread-Index: AQHTj4AHsJhr+18M4E+PKWkEOXafu6N4WSMA Date: Thu, 18 Jan 2018 01:53:32 +0000 Message-ID: <1516240404.15644.23.camel@hxt-semitech.com> References: <1516163877-32396-1-git-send-email-shunyong.yang@hxt-semitech.com> <210f90d0-1588-2185-4845-d5d143183621@arm.com> <1516181177.3280.13.camel@hxt-semitech.com> <1516182426.3280.19.camel@hxt-semitech.com> <1516184428.3280.25.camel@hxt-semitech.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.64.6.73] Content-Type: text/plain; charset="iso-8859-15" Content-ID: <84C5EB80D1875E48A64E1EA80998101C@hxt-semitech.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Barracuda-Connect: localhost[10.128.0.14] X-Barracuda-Start-Time: 1516240405 X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA X-Barracuda-URL: https://192.168.50.101:443/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5070 1.0000 0.7500 X-Barracuda-Spam-Score: 0.75 X-Barracuda-Spam-Status: No, SCORE=0.75 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.46989 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Marc On Wed, 2018-01-17 at 10:43 +0000, Marc Zyngier wrote: > On 17/01/18 10:20, Yang, Shunyong wrote: > > > > Hi, Thomas and Marc, > > > > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > > > > > > On Wed, 17 Jan 2018, Yang, Shunyong wrote: > > > > > > > > > > > > On Wed, 2018-01-17 at 10:33 +0100, Thomas Gleixner wrote: > > > > > > > > > > > > > > > And how is that different from: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The nodes under debugfs irq/irqs describes information of > > > > > > every > > > > > > single > > > > > > irq. > > > > > Not at all. It contains the complete hierarchical information > > > > > of > > > > > each > > > > > virq. > > > > > > > > > I think irq_domain_mapping can provide some high-level > > > > information > > > > in a > > > > summary style. > > > > For example, we can check all the IRQs connect to a specific > > > > irq > > > > chip > > > > or irq domain. > > > You can retrieve the same information from the irq/irqs files. > > > All it > > > takes > > > is a shell script. > > > > > > Aside of that with hierarchical irq domains the old debug output > > > is > > > just > > > useless. > > > > > Umm...Agree. Need I post a patch to remove it? > I'm on it. > In addition to the "%p" to "%px" change in IRQ_DOMAIN_DEBUG you have posted patch to remove it, my original patch includes several other changes: 1. change to "%px" in kasprintf() parameters in function __irq_domain_alloc_fwnode() to build name which reflects the real pointer address from caller, this may be useful when reading debug information.   n = kasprintf(GFP_KERNEL, "irqchip@%px", data); 2. other 3 changes from "%p" to "%px" in existing pr_debug(). Could I submit a V2 patch which depends on your "irqdomain: Kill CONFIG_IRQ_DOMAIN_DEBUG" patch to handle this?  Following is the link of your patch, https://patchwork.kernel.org/patch/10169367/  . Thanks Shunyong