From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: mchristi@redhat.com
Cc: Luis de Bethencourt <luisbg@kernel.org>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] tcmu: Fix trailing semicolon
Date: Thu, 18 Jan 2018 01:23:12 -0800 [thread overview]
Message-ID: <1516267392.24576.246.camel@haakon3.daterainc.com> (raw)
In-Reply-To: <f188423f-8d53-ffe8-7d85-48424e15411b@redhat.com>
On Tue, 2018-01-16 at 10:25 -0600, Michael Christie wrote:
> On 01/16/2018 09:34 AM, Luis de Bethencourt wrote:
> > The trailing semicolon is an empty statement that does no operation.
> > It is completely stripped out by the compiler. Removing it since it doesn't do
> > anything.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> > ---
> >
> > Hi,
> >
> > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> > suggested I fix it treewide [0].
> >
> > Best regards
> > Luis
> >
> >
> > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> >
> > drivers/target/target_core_user.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
Applied. Thanks Luis + MNC.
prev parent reply other threads:[~2018-01-18 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:34 Luis de Bethencourt
2018-01-16 16:25 ` Michael Christie
2018-01-18 9:23 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516267392.24576.246.camel@haakon3.daterainc.com \
--to=nab@linux-iscsi.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luisbg@kernel.org \
--cc=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®