From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755927AbeARNCr (ORCPT ); Thu, 18 Jan 2018 08:02:47 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:15679 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755353AbeARNCo (ORCPT ); Thu, 18 Jan 2018 08:02:44 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20180118130242epoutp036463184237a7757a941986317a193c78~K6SNTdp8I0087400874epoutp03H X-AuditID: b6c32a4b-cf7ff700000011c1-2a-5a609af2e538 Subject: Re: [Patch v6 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10 From: Smitha T Murthy To: Philippe Ombredanne Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux Media Mailing List , LKML , kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, Mauro Carvalho Chehab , pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com, Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" In-Reply-To: Date: Thu, 18 Jan 2018 18:06:21 +0530 Message-ID: <1516278981.22129.12.camel@smitha-fedora> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTURjHO+9l7+toeZpSTwqViyCtNPHC+6FSKWGwPiiEwb7o0NcLOV2b l5SgWZSXShbRxaVld5TUNa9taTZnWpqKzgixNJREUSMtsdQu26vYl8PvOf/nf/7PA4clpZ20 F5uSlsFr01SpMpGYamjz3bN/zhinPDC5RHJD1T00d9f+77BXDRJcSWc+zfX2mhju3blphjOP vae5AUupiLtsqqe5KvtHhntsXia4+/XfGe7P0j/bhWY7w7VN59Ph7nJzZaFIXvvwrPzJ82B5 cV0lks+bt8sd9jwmSqQUH0zgU1OyeG3A4Thx8vVrkZrf+PSEIVGPOiRFyI0FHAwvRyqoIiRm pdiKYHLuHiMUcwjuGGyEUCwgqGu8Sa1ZLF9aVoVmBHPVQy5BimcQrNzxcbIHjoGSW9MiJ4vw Plj42uViT+wP1Y9+uCJIbKLAUtXOOAU3HA21n5oIJ1N4N5TML9NFiGUlOAS66gME3AwrTR7C DHuhWt/tiiXxDmicKSWdTwK+xEDhYi0hNB2F8wPlSGAPmOqoYwT2gvnZZpHA2fBi+SclmPUI yjryVg1h0OoopZzBJPaFGkuAcH0IWqwGWgjeBFeWxglnC2AJFFyUCi0yuN/duRoFMDhTTwss h1H9xOpoETBubWUMyMe4vpnxv22M67nliKxE23iNTp3E60I0QWl8tr9OpdZlpiX5x6erzcj1 v/wUTcjcc8yGMItkGyUFx2OVUlqVpctR2xCwpMxTMquIU0olCaqcXF6bHqvNTOV1NuTNUrKt kojoo0opTlJl8Cd5XsNr11SCdfPSI2NgydgJYvr2UNQH5kFx89SZ0nBHYn/oyFPT8A3/qxW/ xsYVhsi8Z9aweO3Yrj7+XlD65+Fv7dkFO1In7Ufmcy0RCafc+4MducdepXiPM/o+RfZo2AZH 2JZCKKpYNPoSpgbF6O+ybi1Zk++FI7iVNzGV6hjr6505b5NCGzM1QTJKl6wK9CO1OtVffNOH i1sDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWy7bCSnO7HWQlRBlvPMVvcWneO1WL+ESBx ZO1VJouZJ9pZLc6f38BucbbpDbvFpsfXWC0u75rDZtGzYSurxdojd9ktlm36w2SxaOsXdov/ v4HaWvceYbc4/Kad1YHfY9OqTjaPzUvqPZbvNPHo27KK0ePzJjmPK0ca2QPYorhsUlJzMstS i/TtErgypk52LfgnUPF8QloD43HeLkZODgkBE4ldz/YxdTFycQgJ7GaUuNrezAKRkJBY+XsS I4QtLLHy33N2iKLXjBLTfjSygySEBcIkZs54wwZiswnoSHx7fxrMFhHQk1i39CtYA7PAIhaJ M33HwaZyCgRKbL63A2rdPCaJS2v3MoEkmAU0JVq3/wabyiKgKjHz8x/WLkYODl4BU4nTW/Uh TEGJvzuEIQ7SlljXcIYFolNeYvvbOcwTGAVnIRk0C6FjFpKqBYzMqxglUwuKc9Nziw0LDPNS y/WKE3OLS/PS9ZLzczcxguNKS3MH4+Ul8YcYBTgYlXh4O0Lio4RYE8uKK3MPMUpwMCuJ8L7z TogS4k1JrKxKLcqPLyrNSS0+xCjNwaIkzvs071ikkEB6YklqdmpqQWoRTJaJg1OqgdH6zQEu H7dq3W0K3Slvgv+/W3lzybeZ7LPPyxzZuEZi/fzm430qCRVK310PFdyQ5i8V6nn2gnspp4SX 0YfaKzt6Zqu3xOwtVXW5U7CbtfXb1idVceVX529IdZT1d9QRqnsU6KkexPtCfdXf71p37f0d VTasVVonsii/9sKVnTNXB/Qfy5zE8kmJpTgj0VCLuag4EQByzBAOpwIAAA== X-CMS-MailID: 20180118130241epcas5p401fbc387ce2af9cf576ec1b97db55aa4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-MTR: 20180118130241epcas5p401fbc387ce2af9cf576ec1b97db55aa4 CMS-TYPE: 105P X-CMS-RootMailID: 20171208093637epcas1p217ea0e337333ebf6918bc0418753d2af X-RootMTR: 20171208093637epcas1p217ea0e337333ebf6918bc0418753d2af References: <1512724105-1778-1-git-send-email-smitha.t@samsung.com> <1512724105-1778-3-git-send-email-smitha.t@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-12-08 at 14:25 +0100, Philippe Ombredanne wrote: > Smitha, > > On Fri, Dec 8, 2017 at 10:08 AM, Smitha T Murthy wrote: > > Adding the support for MFC v10.10, with new register file and > > necessary hw control, decoder, encoder and structural changes. > > > > CC: Rob Herring > > CC: devicetree@vger.kernel.org > > Signed-off-by: Smitha T Murthy > > Reviewed-by: Andrzej Hajda > > Acked-by: Rob Herring > [] > > --- /dev/null > > +++ b/drivers/media/platform/s5p-mfc/regs-mfc-v10.h > > @@ -0,0 +1,36 @@ > > +/* > > + * Register definition file for Samsung MFC V10.x Interface (FIMV) driver > > + * > > + * Copyright (c) 2017 Samsung Electronics Co., Ltd. > > + * http://www.samsung.com/ > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > Have you considered using the new SPDX ids instead of this fine legalese? e.g.: > > // SPDX-License-Identifier: GPL-2.0 > > This is much shorter and neater (unless you are a legalese lover of > course!) Check also Thomas doc patches and Linus comments on why he > prefers the C++ comment style for these. > > And even better could be this more compact form? I am a big fan of the > C++ style comments for these (and so is Linus) > > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2017 Samsung Electronics Co., Ltd. > // Register definition file for Samsung MFC V10.x Interface (FIMV) driver > > You can also read this fine article from a fellow Samsung colleague > [1]. And if you ever consider doing this for all Samsung's past, > present and future contributions, you will have my deep gratitude > > [1] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/ > Ok I will change to the SPDX license in the next patch series for the v10 register file. Correspondingly for the MFC driver's files I will update the license as a separate patch and submit.