From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932926AbeARPOZ (ORCPT ); Thu, 18 Jan 2018 10:14:25 -0500 Received: from smtprelay0098.hostedemail.com ([216.40.44.98]:34011 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932812AbeARPOO (ORCPT ); Thu, 18 Jan 2018 10:14:14 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3872:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12296:12438:12740:12895:13069:13311:13357:13439:13894:14181:14659:14721:21080:21451:21627:30054:30089:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: bath56_413895501e513 X-Filterd-Recvd-Size: 1613 Message-ID: <1516288446.14023.0.camel@perches.com> Subject: Re: [PATCH-next] MEMCG: memcontrol: make local symbol static From: Joe Perches To: Christopher =?ISO-8859-1?Q?D=EDaz?= Riveros , hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Thu, 18 Jan 2018 07:14:06 -0800 In-Reply-To: <20180118150805.18521-1-chrisadr@gentoo.org> References: <20180118150805.18521-1-chrisadr@gentoo.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-01-18 at 10:08 -0500, Christopher Díaz Riveros wrote: > Fixes the following sparse warning: > > mm/memcontrol.c:1097:14: warning: > symbol 'memcg1_stats' was not declared. Should it be static? > > Signed-off-by: Christopher Díaz Riveros > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c [] > @@ -1094,7 +1094,7 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg) > return false; > } > > -unsigned int memcg1_stats[] = { > +static unsigned int memcg1_stats[] = { This should almost certainly be static const > MEMCG_CACHE, > MEMCG_RSS, > MEMCG_RSS_HUGE,