From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotOWIvHGIt4aGYfZzOsyguMJdRsmDH0z2PW6RdPjMsSvrMKAr9FTGT/lFfjXQ927fkoE/dH ARC-Seal: i=1; a=rsa-sha256; t=1516326744; cv=none; d=google.com; s=arc-20160816; b=ef7Vu2PxBC9ZD+2mDbR0Zhxgb1lhtn/TRte6pdcvncR5pFgrBEybJJuQbEP/PrYSds DpaVrk1ChLoHH9Fh+f0ARBei5xFxXgk9I4AgaQlLD1hSGei3Xz5o7ljjyix7CzvPRl7v cCYdpTh0L8H2CR/+6/uTCXDUnDCg62AXEGGvA15zTI9LyZqsT8zMan68N1OfA09cM8zW HvxWNPJES2vVki5L8goc+0WzTzJ3Ue9KyRIs4frnY70EzoFKl7j4E3vn5nB3TBMdL77n bG/GX2N2IRTuI5LLc2ixnOJfkgPBw2DKHERDYZEZjBa/LftqOb1dGT7uRQ+LKhEStLjZ rQIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=6GeyvMj3uUHggjoKVxYl6rSX+IoO+spyl/Krwt5gUt8=; b=Hqb9uaJhh3qJZlFu+kjL/dnwRcTRB+jWo9L1ZkxhgbfMMWMmbWmngUUMyJxaOnZUTL dQlfQfOCWnQVBmeWD4rzKxQlbrKv+JTzFQEjGRgJ9xmb1zeA8DDl3ZRJQ5v6AWxYFFKb lrRu6CiSLf9y/FBo+MTlkxPgnTE1k5+C7bQfzpBk7R9QiKQTfCTv7QoPJlVou0GPQJbU 8NXAQdLFugG0OG82mksVx2imFTBvkH4puuLneBaBxGjVyOl3pnX/nWWBqDrrnETTR42U x+ieqCxcZzWuAZJSfenrv12IY7kCWzbeRcQFpoCmbkwFmiph74olPNLLQUeMydc0Sa7Y v9yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=bV5ic1mV; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=bV5ic1mV; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755643AbeASBwW (ORCPT ); Thu, 18 Jan 2018 20:52:22 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:39260 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755502AbeASBwA (ORCPT ); Thu, 18 Jan 2018 20:52:00 -0500 From: Ram Pai To: mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, arnd@arndb.de Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, linuxram@us.ibm.com Subject: [PATCH v10 07/27] powerpc: cleanup AMR, IAMR when a key is allocated or freed Date: Thu, 18 Jan 2018 17:50:28 -0800 Message-Id: <1516326648-22775-8-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com> References: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589983832398166389?= X-GMAIL-MSGID: =?utf-8?q?1589983832398166389?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Cleanup the bits corresponding to a key in the AMR, and IAMR register, when the key is newly allocated/activated or is freed. We dont want some residual bits cause the hardware enforce unintended behavior when the key is activated or freed. Reviewed-by: Thiago Jung Bauermann Signed-off-by: Ram Pai --- arch/powerpc/include/asm/pkeys.h | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/include/asm/pkeys.h b/arch/powerpc/include/asm/pkeys.h index 1e8cef2..9964b46 100644 --- a/arch/powerpc/include/asm/pkeys.h +++ b/arch/powerpc/include/asm/pkeys.h @@ -69,6 +69,8 @@ static inline bool mm_pkey_is_allocated(struct mm_struct *mm, int pkey) __mm_pkey_is_allocated(mm, pkey)); } +extern void __arch_activate_pkey(int pkey); +extern void __arch_deactivate_pkey(int pkey); /* * Returns a positive, 5-bit key on success, or -1 on failure. * Relies on the mmap_sem to protect against concurrency in mm_pkey_alloc() and @@ -96,6 +98,12 @@ static inline int mm_pkey_alloc(struct mm_struct *mm) ret = ffz((u32)mm_pkey_allocation_map(mm)); __mm_pkey_allocated(mm, ret); + + /* + * Enable the key in the hardware + */ + if (ret > 0) + __arch_activate_pkey(ret); return ret; } @@ -107,6 +115,10 @@ static inline int mm_pkey_free(struct mm_struct *mm, int pkey) if (!mm_pkey_is_allocated(mm, pkey)) return -EINVAL; + /* + * Disable the key in the hardware + */ + __arch_deactivate_pkey(pkey); __mm_pkey_free(mm, pkey); return 0; -- 1.7.1