From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, ebiggers@google.com,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 00/15] KEYS: Fixes
Date: Mon, 16 Oct 2017 23:09:31 +0100 [thread overview]
Message-ID: <15166.1508191771@warthog.procyon.org.uk> (raw)
In-Reply-To: <20171016183141.GD121701@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> > - if (test_bit(KEY_FLAG_INSTANTIATED, &key->flags))
> > + if (state == KEY_IS_INSTANTIATED)
> > atomic_dec(&key->user->nikeys);
>
> This changes the behavior. Previously ->nikeys counted both negatively and
> positively instantiated keys, while this change implies that it now will only
> count positively instantiated keys. I think you meant 'state !=
> KEY_IS_UNINSTANTIATED'? Renaming KEY_IS_INSTANTIATED to KEY_IS_POSITIVE or
> KEY_IS_POSITIVELY_INSTANTIATED also might help reduce this confusion.
Yeah - I think I'm confusing myself by overloading 'instantiated' in my mind.
David
next prev parent reply other threads:[~2017-10-16 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 16:17 David Howells
2017-10-12 16:26 ` David Howells
2017-10-12 18:56 ` Eric Biggers
2017-10-13 15:39 ` David Howells
2017-10-16 18:31 ` Eric Biggers
2017-10-16 22:09 ` David Howells [this message]
2017-10-16 22:27 ` David Howells
2017-10-17 17:52 ` Eric Biggers
2017-10-12 20:15 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15166.1508191771@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome