From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226coupj8RAfsErdZp7was6qnrY1GG3zSJ/6L7uNrk2ALcA0BUd/9nP80cFV//WmTENolI3O ARC-Seal: i=1; a=rsa-sha256; t=1516647511; cv=none; d=google.com; s=arc-20160816; b=PCMdpGHUOTFk9TBWTX0zlVRs+uVh1MwiC9C+YlZp7JqZJByusluhmFMTSx4ueneNor 4KsjWyNAmzQ9LC/sUW4r2PGFk7DUOOCGwgL/jhmT+Pyw8+KL64+CBDxI3BH97sknMpe/ rElfPpBcvbU9lwhtAc4u7xvI/576UkJ1AzG4sEVjN/STu0deYaSFUYogBy2uddui1IRI pk4hfRPKuy3oVXkY2YiniUpUPxea6PWR1TKk/LRTQ2g5OvQ16oQqe7XZYID8AbjPgC6A 8SuW2mcu+usRVEbBRVTtqLXbqwI5zHu/HpGi2zqabZVDEYNj6JLWvImvz6SCcmxI1MY3 g8cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=IuTMdzGKMwEhmHeWKDM27vVYTihoG+UGFecT3N4O5xk=; b=lj+lWVW08GqFYIM46oS9H6zNkDnGlL5abvUVZVQ6L+hXu2tLZZWsaNWO8uEZt+4QxE VAicB3eg3XDplub90t8afndtvZbTD0VJgSAteMsz5lihxyHZzgIrv2j7jRzQ6uZ5B89f VFDwjTJjC1zV3p0TnfLDiniAVgmGmRfUX57nb0xfajCT8wN3ShI2hJj9652QX/cuN9oM XP4qm1e1rVOTk+kTAkPHoMCmoDAYNwdJCiC6ljuCbcengTrq3C/WxHxj4HvkOlo278Gp 7c9877F+DCuGRBY2H4CMpnWzsSWBinucNZL+3awr/0YV2FmY6wmptPZ01/Sl5s7c1eDD ibog== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ry85BsV+; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ry85BsV+; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbeAVS5r (ORCPT ); Mon, 22 Jan 2018 13:57:47 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35972 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbeAVSxO (ORCPT ); Mon, 22 Jan 2018 13:53:14 -0500 From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, akpm@linux-foundation.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, linuxram@us.ibm.com, arnd@arndb.de Subject: [PATCH v10 09/24] selftests/vm: fix alloc_random_pkey() to make it really random Date: Mon, 22 Jan 2018 10:52:02 -0800 Message-Id: <1516647137-11174-10-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> References: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590320180930036153?= X-GMAIL-MSGID: =?utf-8?q?1590320180930036153?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: alloc_random_pkey() was allocating the same pkey every time. Not all pkeys were geting tested. fixed it. Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index aaf9f09..2e4b636 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -24,6 +24,7 @@ #define _GNU_SOURCE #include #include +#include #include #include #include @@ -602,13 +603,15 @@ int alloc_random_pkey(void) int alloced_pkeys[NR_PKEYS]; int nr_alloced = 0; int random_index; + memset(alloced_pkeys, 0, sizeof(alloced_pkeys)); + srand((unsigned int)time(NULL)); /* allocate every possible key and make a note of which ones we got */ max_nr_pkey_allocs = NR_PKEYS; - max_nr_pkey_allocs = 1; for (i = 0; i < max_nr_pkey_allocs; i++) { int new_pkey = alloc_pkey(); + if (new_pkey < 0) break; alloced_pkeys[nr_alloced++] = new_pkey; @@ -624,13 +627,14 @@ int alloc_random_pkey(void) /* go through the allocated ones that we did not want and free them */ for (i = 0; i < nr_alloced; i++) { int free_ret; + if (!alloced_pkeys[i]) continue; free_ret = sys_pkey_free(alloced_pkeys[i]); pkey_assert(!free_ret); } - dprintf1("%s()::%d, ret: %d pkey_reg: 0x%x shadow: 0x%x\n", __func__, - __LINE__, ret, __rdpkey_reg(), shadow_pkey_reg); + dprintf1("%s()::%d, ret: %d pkey_reg: 0x%x shadow: 0x%016lx\n", + __func__, __LINE__, ret, __rdpkey_reg(), shadow_pkey_reg); return ret; } -- 1.7.1