From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226F6tI/IyXf8U24uPSw/88fVjQGEMfg08puyP+RyuzTBwoemWsCrzIWwKffZqjk4SV8VQrT ARC-Seal: i=1; a=rsa-sha256; t=1516647525; cv=none; d=google.com; s=arc-20160816; b=OFJSP5nAx23c7PO619rMsFAxvsnejWGIpmZfTDn0LsOmTCGOKN0o9BAUgWZAr+n83S 24xlE4kBKv189+3YNW9EVtmlQ1hzfYg80uCDXsluimJBKqz/CuPKosIOiSOGhwo08/YP 5GW/pSNUgVA9TpYeqYXLig81bCnemOlnEDagfELJN2V/iglqre8rD0LEtDb1VaFxvVrN HReLhzPkG6dfufV0jeGKwvwWMXnTCLR0kGgd6+CeTlj87X88/fWA5k2BP2p0gszs8+NM nul5+MTndYK46sstGJp3J+BWRIodUu6IwClT2DQ9/G7AiTRqnqjCAeIp3wrAwiwDnQl5 3tSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=vOQYDLV7Jp3ZhyoJw6zVbkeV2RxNFf9B89/7HhKBxcc=; b=RCQQBJPFwAx/TW6X7BzPhL55SwuXd+Xx3MykHMUDGPXy0/vB+4t/h/KHObybu6AgLs 5wRJ5001M2xLa3RUZZdSS4GXEUPpsqCD6iPrXSnMvqKCkrd4BVruSNIMawjtW63b5W3o BZBSAdmYy8BqwCiEcBYtaDI4vkZ9CObiUKK8rqsh09CdBkNqJVLKxszzC2wPhj1fXSaK BTphKsW6Vjpq/PUGb8ytDNsMrXhw9UUVVgrSXyIOlOSGAWDcQceSTjgknmJ6UQfOHSr/ wewH2Vxj0IUdhEbfv7uWm1KTvo887GzJlFVTED8+bxG+sMTuhBVy6NWVFLcff9ri6YhY muOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=a6IgMnee; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=a6IgMnee; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbeAVS5q (ORCPT ); Mon, 22 Jan 2018 13:57:46 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:34744 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbeAVSxU (ORCPT ); Mon, 22 Jan 2018 13:53:20 -0500 From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, akpm@linux-foundation.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, linuxram@us.ibm.com, arnd@arndb.de Subject: [PATCH v10 11/24] selftests/vm: pkey register should match shadow pkey Date: Mon, 22 Jan 2018 10:52:04 -0800 Message-Id: <1516647137-11174-12-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> References: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590320195665035847?= X-GMAIL-MSGID: =?utf-8?q?1590320195665035847?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: expected_pkey_fault() is comparing the contents of pkey register with 0. This may not be true all the time. There could be bits set by default by the architecture which can never be changed. Hence compare the value against shadow pkey register, which is supposed to track the bits accurately all throughout Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 254b66d..6054093 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -926,10 +926,10 @@ void expected_pkey_fault(int pkey) pkey_assert(last_pkey_faults + 1 == pkey_faults); pkey_assert(last_si_pkey == pkey); /* - * The signal handler shold have cleared out PKEY register to let the + * The signal handler shold have cleared out pkey-register to let the * test program continue. We now have to restore it. */ - if (__rdpkey_reg() != 0) + if (__rdpkey_reg() != shadow_pkey_reg) pkey_assert(0); __wrpkey_reg(shadow_pkey_reg); -- 1.7.1