From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226KhqroeWs6uv+sv/xg9CNanLT3fx3lfxpNzjR7oSDL4WqID0Mz8ZNEHWf1SVvrL7BAHXRQ ARC-Seal: i=1; a=rsa-sha256; t=1516647420; cv=none; d=google.com; s=arc-20160816; b=o1bnF/GHIW5Od7qoYzDTMEPILCO3gcTc5H2+FN6OzgeCZ4V4Y41O1LJ0kB9uFmEL5/ PQy0VraafHOITgyjLeNyYCo8PSyAk2TdQd0JNTU1EtJw0et1Fdn83WrOG9ZfGoe6OMw8 2PZpEWDLzziRo6Smoy87ml6axJfDsffwApFsa2VmYCoR+1MwceC6Ml9LyOCN45JtN9ug azwL541PP7zb9rx+Dx9iomM/so9ENnN+rIArtkuSN5Z9YvE6j1mA1dRBBj0UhpNCEAHZ PmPkygTIHt/1NRHjY45eagCZEJCu75J+q0ODU1FGbkSilgS3AkRhBXAdh8mAjKyGIw4b Wl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=QquuAKEL1Y+0mc6BB5laMxFm4K+RSzJXHpBd9+lZWwo=; b=ARW4P4rcld59Q0ngx06hPtxCamOixZo+QLsaMQ9Y8kt4TUj8czIRH9SK91qOjbOfdH 4g9rIvZJ63+kkE8uFXEjUgaRQMgsNReiug0Hjekj2IndY4CVfsDXKzK8YhNrHVhbV4zI 1K9+o+6W8C/Kf+DBcLZD0052h41IZUKpL8JKItNkZ7YJejzakwW8pQkK3El10ysaIdAQ QoSoAawlHw8gB05UeqokUuANf75usV5RWXR6MgdHWN1oHfAFYL7OjnwtfI9kbZ59B/zY FaqfyQJ16SMCjaqaq/AmEx6S5LGgz0gxxOwWCkZruJfCkk0MFGOn0XnYeig66O65Aw4K 5QdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=DkXxdHSP; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=DkXxdHSP; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458AbeAVSxc (ORCPT ); Mon, 22 Jan 2018 13:53:32 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:47074 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbeAVSx3 (ORCPT ); Mon, 22 Jan 2018 13:53:29 -0500 From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, akpm@linux-foundation.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, linuxram@us.ibm.com, arnd@arndb.de Subject: [PATCH v10 14/24] selftests/vm: clear the bits in shadow reg when a pkey is freed. Date: Mon, 22 Jan 2018 10:52:07 -0800 Message-Id: <1516647137-11174-15-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> References: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590320085994835403?= X-GMAIL-MSGID: =?utf-8?q?1590320085994835403?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: When a key is freed, the key is no more effective. Clear the bits corresponding to the pkey in the shadow register. Otherwise it will carry some spurious bits which can trigger false-positive asserts. Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 55a25e1..d1cbdfe 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -586,7 +586,8 @@ int sys_pkey_free(unsigned long pkey) int ret = syscall(SYS_pkey_free, pkey); if (!ret) - shadow_pkey_reg &= reset_bits(pkey, PKEY_DISABLE_ACCESS); + shadow_pkey_reg &= reset_bits(pkey, + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); return ret; } -- 1.7.1