From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224vLH+N5Pui07cc6aUT8ksTWwTZsfCH7O+5ImnBYMH1Ik4Fdz2yLS0NYFqpCmP5K8m2Wuk6 ARC-Seal: i=1; a=rsa-sha256; t=1516647531; cv=none; d=google.com; s=arc-20160816; b=Bjlbhr2txuXhKMRda/WwmFSvh/cPohauezVw1M7vCAEZ9SyJw2pp/kieOyGwtPg9iN zluMS/U7KC70sutZh94WhrvThbOa8Y332+lUFunrn8ekCbAxIUcEi+90A+26g2ZPB2bh Z/uJKq80CFhAVvF5RJ4w4Sov/E3dYIE1gfq3JvwjD2XSwuDUj5Of4koGYBp2DS6KzVGG +RJZwd9coYmTqVoPQqHSbtJ0Ywo6rT2dQls0r0rHv3WIVxX1hsmy02icVK2C0xiF/eV/ 0TC76NSWr9/uk9w0oVv7wBHfADV0cEs4YkQZMFY/LjF7dntxY3yp9dvxhHz7hEeUD827 R8jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=DX1s5ZrzMCz0NcUWR/TDjI7WPz1D0QclPqFv82tucIc=; b=btk1YuGz+CdR3PpXWPrqeR7h0Dz5fQ2F8Du+0qNDBPSVJj0DvTrEO8UFzxCd7g3SEO gEy9TblsxnSW8Us0wKP4F8rK4uas/Y5PodmtbM7dymraTwPx9iFYy0Infw/fYbJ5mrpF vvYtwjsc65Pnz20Z5uBzi42ioC1r3uSmrFnmvDNOm01HTBqumpYMQ+d/ElE4bYL9+y2/ B5zzm2DrvWEdLBxRY/4z52nCXi6KXyq2wPGwwqDos/r4tZtdls8jpOpn/LWS0Avxgdsr I+O1LC91T9HgXIxeCenrfpK7W51b9A8IHxt4QDNmRFJYYNFNTwUBrmTDs4EqkwW555IR nLwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ftlri+eQ; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ftlri+eQ; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbeAVSxO (ORCPT ); Mon, 22 Jan 2018 13:53:14 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:40378 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbeAVSxF (ORCPT ); Mon, 22 Jan 2018 13:53:05 -0500 From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, akpm@linux-foundation.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, linuxram@us.ibm.com, arnd@arndb.de Subject: [PATCH v10 06/24] selftests/vm: fix the wrong assert in pkey_disable_set() Date: Mon, 22 Jan 2018 10:51:59 -0800 Message-Id: <1516647137-11174-7-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> References: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590320202110334630?= X-GMAIL-MSGID: =?utf-8?q?1590320202110334630?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: If the flag is 0, no bits will be set. Hence we cant expect the resulting bitmap to have a higher value than what it was earlier. Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 83216c5..0109388 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -443,7 +443,7 @@ void pkey_disable_set(int pkey, int flags) dprintf1("%s(%d) pkey_reg: 0x%lx\n", __func__, pkey, rdpkey_reg()); if (flags) - pkey_assert(rdpkey_reg() > orig_pkey_reg); + pkey_assert(rdpkey_reg() >= orig_pkey_reg); dprintf1("END<---%s(%d, 0x%x)\n", __func__, pkey, flags); } -- 1.7.1