From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224J/PbPjGP5xiqkvqYQbWNhe3d8Cjal0t8DTcKhdiWLlYSnDizuRJ9fSsVWONysnx+9WzeX ARC-Seal: i=1; a=rsa-sha256; t=1516647591; cv=none; d=google.com; s=arc-20160816; b=HUaXFLAzN8F8JpJ8wdHb7oMPS/aJMsHdsVps/r8C+TDK4Mxz2a04QY6gsLiorZgy58 V1M1DhHwys+Si+OQ3zZ9gvg1P+0HcjL6xSik1nrREwe0Cr4UHKUFNvyzJJ8fTVh/KL1s Cdjz5ACiIfEWHLGnomgnxMJ94t4xf1h41zi6PNpWN+LOYSrzBqYxQugKCJIIE7MQldNR v+gb83c1D0N4aZw932nb96NjVw/qH51zXLu+ccIqNA9nEW/vhK0T/HFr7bKlUQVp1Jaw LYgHpzv1Qa6g29vX+FOaKG39gtKUZRmVfzkQtWkERUjwdnkF95OTf+jHuSuDEGr5zjY2 jHsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=w12fbkexVXlx9ldSkr8NS5kdjzhmgPvkg8EHIruDBHM=; b=RtyouSBoerf7kxezjhmuJvyiTUS2dZNQo8YMMvWD8zZlQfwMPeBSXFzcP1t3EbsPNz 1aPQ8OeUAxOilTiiPhFe0xACMxqa43YsLV1xi2SKungB2eyctFGvXBUHVVhD+L1DXbta ljYBTf729/XGGH0d2WRgvgK/blOsYUbRqm/PtjCBDJpA3hBf5UUgxzQYcxAC4QD3x1i/ hL/mud1BfJwSpM6RBlLFALM+u4g8D7sKVuAJYgsTMkkohuwtV4ybbhDJiM0LTltlf4bq usK52oVbHKZzS41LOdfpbq4994btdU+5xtn0ll62W/yIIaH//07+By3HP3u9+ISMD7e+ FC6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=F6ThyQ2T; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=F6ThyQ2T; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbeAVS7V (ORCPT ); Mon, 22 Jan 2018 13:59:21 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36866 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbeAVSxI (ORCPT ); Mon, 22 Jan 2018 13:53:08 -0500 From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, akpm@linux-foundation.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com, linuxram@us.ibm.com, arnd@arndb.de Subject: [PATCH v10 07/24] selftests/vm: fixed bugs in pkey_disable_clear() Date: Mon, 22 Jan 2018 10:52:00 -0800 Message-Id: <1516647137-11174-8-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> References: <1516647137-11174-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590320264471422263?= X-GMAIL-MSGID: =?utf-8?q?1590320264471422263?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: instead of clearing the bits, pkey_disable_clear() was setting the bits. Fixed it. Also fixed a wrong assertion in that function. When bits are cleared, the resulting bit value will be less than the original. Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 0109388..ca54a95 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -461,7 +461,7 @@ void pkey_disable_clear(int pkey, int flags) pkey, pkey, pkey_rights); pkey_assert(pkey_rights >= 0); - pkey_rights |= flags; + pkey_rights &= ~flags; ret = pkey_set(pkey, pkey_rights, 0); /* pkey_reg and flags have the same format */ @@ -475,7 +475,7 @@ void pkey_disable_clear(int pkey, int flags) dprintf1("%s(%d) pkey_reg: 0x%016lx\n", __func__, pkey, rdpkey_reg()); if (flags) - assert(rdpkey_reg() > orig_pkey_reg); + assert(rdpkey_reg() < orig_pkey_reg); } void pkey_write_allow(int pkey) -- 1.7.1