From: David Woodhouse <dwmw2@infradead.org>
To: Waiman Long <longman@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>, Jeff Law <law@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jiri Kosina <jikos@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Dave Hansen <dave.hansen@intel.com>,
Kees Cook <keescook@google.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linux-foundation.org>,
Paul Turner <pjt@google.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH] x86/retpoline: Remove the esp/rsp thunk
Date: Mon, 22 Jan 2018 22:21:47 +0000 [thread overview]
Message-ID: <1516659707.9521.77.camel@infradead.org> (raw)
In-Reply-To: <1516658974-27852-1-git-send-email-longman@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Mon, 2018-01-22 at 17:09 -0500, Waiman Long wrote:
> It doesn't make sense to have an indirect call thunk with esp/rsp as
> retpoline code won't work correctly with the stack pointer register.
> Removing it will help compiler writers to catch error in case such
> a thunk call is emitted incorrectly.
>
> Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support")
> Suggested-by: Jeff Law <law@redhat.com>
> Signed-off-by: Waiman Long <longman@redhat.com>
Acked-by: David Woodhouse <dwmw@amazon.co.uk>
I spotted that and *almost* removed it a couple of times in other
refactoring, but after abandoning those I forgot to come back and do
just this. Thanks.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
next prev parent reply other threads:[~2018-01-22 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 22:09 Waiman Long
2018-01-22 22:21 ` David Woodhouse [this message]
2018-01-24 11:42 ` [tip:x86/pti] " tip-bot for Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516659707.9521.77.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=law@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®