From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2255tgz5Y4Tk7EKcZrjiSoPdBo+YFD0hjdSghPumfkQ1/mcgecyGMs839CiC+i0HDM6BB9kx ARC-Seal: i=1; a=rsa-sha256; t=1516733073; cv=none; d=google.com; s=arc-20160816; b=u9MkxMNEZw+Dm1pGP+V1+tZrQFP84sI5qtQ8bUks23D9srdHIF5bzupoVmI4vMQYel VMOSMNNAV1hAhqBnM2SEhRii6XJ2k5tn4dXY8VHrdqHkyZKvyKtnE4nzaJEgLM88In6+ vCkdmuDjHpaFRlBzX9kF8iCwCt/iONQ+CiwRGwgo4pGnO3S2UJixLQo9u7NtjIfg/J9j 5XcUSPVgAeMY90gpXig7pku1XFFQ/IxqvKxsLSbE/AoMdYz1w5h977VcMj9OMgyPiFHs gmDdoTcFeTQZspfsvscOh6n+UkRZ0UJkFCbFQ5eBhXDJVAJeGhU0r3adr+oSFILrBkg2 9oSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to:date :cc:to:from:subject:message-id:arc-authentication-results; bh=dkUWlZciHqCk2IGG8byXpcASh8RQshC053Lcz6YirOY=; b=H/uUw1aMxMnJp7HwSP9JjEDf6zOmsybn0nL7IUZfpqkuEQa8E8M95CRntR8Dbq4q69 Tg9BqgChQ0e2JKBoOvkxqDyzb+25AOcnkSmhEmrkiwQD9iL4ciBFWabUCsMsTKt5RUJd +C0Kh/X8SMM+bGXu7DmsvkJ+To4m7Cwet9WbTizoWngQ/6qfXFI+e41G38wCY0Fz3VR9 gDvH7MzBbeQ5L5gOnEZ8+ZVt+/M4AA88uHQrSx0PnAs/4KgoMicscblTslNMyaXfMnkV Up1x/cxIx0hfmg9Cw7SYailaxhCSBfyeL9eeAdq8oTw7JhdA3AholQa58sAkM9Dx7War KSIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of sean.wang@mediatek.com designates 210.61.82.183 as permitted sender) smtp.mailfrom=sean.wang@mediatek.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of sean.wang@mediatek.com designates 210.61.82.183 as permitted sender) smtp.mailfrom=sean.wang@mediatek.com X-UUID: a8a8e678d43f4017b18f988ca0187185-20180124 Message-ID: <1516733067.15199.41.camel@mtkswgap22> Subject: Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes From: Sean Wang To: Philippe Ombredanne CC: Rob Herring , Matthias Brugger , Mark Rutland , , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , LKML , Mark Brown , "Greg Kroah-Hartman" Date: Wed, 24 Jan 2018 02:44:27 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590379865638636373?= X-GMAIL-MSGID: =?utf-8?q?1590409899652580467?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi, Philippe Really appreciate your info and detailed explanation. it's clear how correct way to add GPDX license identifier. I will have a follow-up. Sean On Tue, 2018-01-23 at 11:46 +0100, Philippe Ombredanne wrote: > Sean, > sorry for the late reply and thanks you for this research. > > On Fri, Jan 12, 2018 at 4:33 AM, Sean Wang wrote: > > Currently, I'm really confused about what usage STYLE of SPDX license > > identifier I should use for each type of file. > > > > could you point me where I can find the related document describing SPDX > > usage style for those files expected by the community in the future? > > The doc is in this patchset [1] > > [1] https://lkml.org/lkml/2017/12/28/326 > > > > I found more than one way STYLE of SPDX present at current code, for > > example as below. If there's no absolute definition for them, and then > > which way that is better? > > 1) > > for *.dts, applied with "// " at head or within " /* */ " not at head > > such as > > > > arch/arm/boot/dts/bcm953012hr.dts:2: * SPDX-License-Identifier: > > BSD-3-Clause > > This is a "style bug". The comment style for .dts should be // > > > 2) > > for *.c, applied with "// " at head or within " /* */ " not at head > > such as > > drivers/soc/xilinx/zynqmp/pm.c:10: * SPDX-License-Identifier: GPL-2.0+ > > This is a "style bug". The comment style for .c should be // > > > 3) > > for *.h, applied with "// " at head or within " /* */ " at head > > such as > > drivers/usb/dwc3/gadget.h:1:// SPDX-License-Identifier: GPL-2.0 > > This is a "style bug". The comment style for .h should be /**/ > > > 4) > > no issue, Makefile, or Kconfig, definitely applied with "# " at head > > That's the correct way. > > So the net-net is that these "style bugs" should be fixed. >