From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "joe@perches.com" <joe@perches.com>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"axboe@fb.com" <axboe@fb.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros
Date: Tue, 23 Jan 2018 23:12:20 +0000 [thread overview]
Message-ID: <1516749137.3339.62.camel@wdc.com> (raw)
In-Reply-To: <1516711552.8378.30.camel@perches.com>
On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote:
> Perhaps the email subject could be improved to describe
> the new macro and as well, this macro, without a pr_fmt
> define somewhat above it loses the __func__ output too.
Hmm ... I thought that the pr_debug() output can be configured to include
the function name (__func__)? From
https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html:
The flags are:
p enables the pr_debug() callsite.
f Include the function name in the printed message
l Include line number in the printed message
m Include module name in the printed message
t Include thread ID in messages not generated from interrupt context
_ No flags are set. (Or'd with others on input)
Bart.
next prev parent reply other threads:[~2018-01-23 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 10:55 Johannes Thumshirn
2018-01-23 12:45 ` Joe Perches
2018-01-23 23:12 ` Bart Van Assche [this message]
2018-01-24 2:53 ` Joe Perches
2018-01-24 8:03 ` Johannes Thumshirn
2018-01-24 11:13 ` Joe Perches
2018-01-24 16:24 ` Bart Van Assche
2018-01-24 16:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516749137.3339.62.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=joe@perches.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®