From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
jgross@suse.com, douly.fnst@cn.fujitsu.com, kkamagui@gmail.com,
gregkh@linuxfoundation.org, mka@chromium.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [PATCH] kernel: x86: apic: Replace GFP_ATOMIC with GFP_KERNEL in __add_pin_to_irq_node
Date: Wed, 24 Jan 2018 09:40:15 +0800 [thread overview]
Message-ID: <1516758015-7236-1-git-send-email-baijiaju1990@gmail.com> (raw)
The function __add_pin_to_irq_node is not called in atomic context.
Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 201579d..665c013 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -379,7 +379,7 @@ static int __add_pin_to_irq_node(struct mp_chip_data *data,
if (entry->apic == apic && entry->pin == pin)
return 0;
- entry = kzalloc_node(sizeof(struct irq_pin_list), GFP_ATOMIC, node);
+ entry = kzalloc_node(sizeof(struct irq_pin_list), GFP_KERNEL, node);
if (!entry) {
pr_err("can not alloc irq_pin_list (%d,%d,%d)\n",
node, apic, pin);
--
1.7.9.5
next reply other threads:[~2018-01-24 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 1:40 Jia-Ju Bai [this message]
2018-02-13 15:56 ` Ingo Molnar
2018-02-13 16:12 ` Thomas Gleixner
2018-02-13 16:16 ` Ingo Molnar
2018-02-13 16:20 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516758015-7236-1-git-send-email-baijiaju1990@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kkamagui@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®