From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933653AbeAXL51 (ORCPT ); Wed, 24 Jan 2018 06:57:27 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:42331 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933363AbeAXL50 (ORCPT ); Wed, 24 Jan 2018 06:57:26 -0500 Message-ID: <1516795026.6411.7.camel@pengutronix.de> Subject: Re: [PATCH] drm/etnaviv: fix '%x' warning From: Lucas Stach To: "Gustavo A. R. Silva" , Russell King , Christian Gmeiner , David Airlie Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Date: Wed, 24 Jan 2018 12:57:06 +0100 In-Reply-To: <20180123170753.GA26470@embeddedgus> References: <20180123170753.GA26470@embeddedgus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva: > Fix the following warning by using %zx instead of %x for variable of > type size_t: > > warning: format ‘%x’ expects argument of type ‘unsigned int’, but > argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=] > > Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions") > Signed-off-by: Gustavo A. R. Silva Thanks for the patch, but I already have an equivalent change queued up. Regards, Lucas > --- > This code was compiled with GCC 7.2.0 > >  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c > index d113fe0..49e0497 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c > @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain, > >   size_t pgsize = SZ_4K; >   > >   if (!IS_ALIGNED(iova | size, pgsize)) { > > - pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n", > > + pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n", > >          iova, size, pgsize); > >   return; > >   } > @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain, > >   int ret = 0; >   > >   if (!IS_ALIGNED(iova | paddr | size, pgsize)) { > > - pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n", > > + pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n", > >          iova, &paddr, size, pgsize); > >   return -EINVAL; > >   }