From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965018AbeAXSWv (ORCPT ); Wed, 24 Jan 2018 13:22:51 -0500 Received: from mail-edgeka24.fraunhofer.de ([153.96.1.24]:62789 "EHLO mail-edgeKA24.fraunhofer.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964850AbeAXSWt (ORCPT ); Wed, 24 Jan 2018 13:22:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EcAwD8y2ha/xoHYZleGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYNCZnQnB4NWixiNc4ICmRRDCiOBXoM6AhqEZ1gUAQEBAQEBAQE?= =?us-ascii?q?CA2gogmcESyovAQEBAQEBAQEBAQEBAQEBGgINXQEBAQQjEUUQAgEIFQMCAiYCA?= =?us-ascii?q?gIwFRACBAENBYo0ARCzC4InhBYBAYZDAQEBAQEBBAEBAQEBAQEBAQEBGAWBD4N?= =?us-ascii?q?DgQ6BB4FYgWeDLoMvAgKBbzqCXYJlBaQABgKBGoZ4jU2MJod+jVmJfoE8NiOBU?= =?us-ascii?q?HGCe4QcATp4AQGNEYEXAQEB?= X-IPAS-Result: =?us-ascii?q?A2EcAwD8y2ha/xoHYZleGQEBAQEBAQEBAQEBAQcBAQEBAYN?= =?us-ascii?q?CZnQnB4NWixiNc4ICmRRDCiOBXoM6AhqEZ1gUAQEBAQEBAQECA2gogmcESyovA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEBGgINXQEBAQQjEUUQAgEIFQMCAiYCAgIwFRACBAENBYo?= =?us-ascii?q?0ARCzC4InhBYBAYZDAQEBAQEBBAEBAQEBAQEBAQEBGAWBD4NDgQ6BB4FYgWeDL?= =?us-ascii?q?oMvAgKBbzqCXYJlBaQABgKBGoZ4jU2MJod+jVmJfoE8NiOBUHGCe4QcATp4AQG?= =?us-ascii?q?NEYEXAQEB?= X-IronPort-AV: E=Sophos;i="5.46,408,1511823600"; d="scan'208";a="3975650" X-IronPort-AV: E=Sophos;i="5.46,408,1511823600"; d="scan'208";a="15941983" From: "Auer, Lukas" To: "linux-kernel@vger.kernel.org" , "aymen.sghaier@nxp.com" , "horia.geanta@nxp.com" , "pure.logic@nexus-software.ie" , "linux-crypto@vger.kernel.org" CC: "peng.fan@nxp.com" , "davem@davemloft.net" , "ryan.harkin@linaro.org" , "fabio.estevam@nxp.com" , "rui.silva@linaro.org" , "herbert@gondor.apana.org.au" Subject: Re: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node Thread-Topic: [RESEND PATCH 3/6] ARM: dts: imx7s: add CAAM device node Thread-Index: AQHTlSLNQqw1jILxbE6hMrmObxKZgKODQtSA Date: Wed, 24 Jan 2018 18:12:46 +0000 Message-ID: <1516817565.29323.74.camel@aisec.fraunhofer.de> References: <1516805435-15034-1-git-send-email-pure.logic@nexus-software.ie> <1516805435-15034-4-git-send-email-pure.logic@nexus-software.ie> In-Reply-To: <1516805435-15034-4-git-send-email-pure.logic@nexus-software.ie> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.80.233.51] x-tm-as-product-ver: SMEX-11.0.0.4179-8.200.1013-23616.006 x-tm-as-result: No--14.138700-8.000000-31 x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No Content-Type: text/plain; charset="utf-8" Content-ID: <8656C3E1D17BA84C8658E91BD9397841@xch.fraunhofer.de> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0OIMvvN026284 On Wed, 2018-01-24 at 14:50 +0000, Bryan O'Donoghue wrote: > From: Rui Miguel Silva > > Add CAAM device node to the i.MX7s device tree. > > Signed-off-by: Rui Miguel Silva > Cc: "Horia Geantă" > Cc: Aymen Sghaier > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Lukas Auer > Signed-off-by: Bryan O'Donoghue > --- > arch/arm/boot/dts/imx7s.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7s.dtsi > b/arch/arm/boot/dts/imx7s.dtsi > index 82ad26e..0da146e 100644 > --- a/arch/arm/boot/dts/imx7s.dtsi > +++ b/arch/arm/boot/dts/imx7s.dtsi > @@ -805,6 +805,32 @@ > status = "disabled"; > }; > > + crypto: caam@30900000 { > + compatible = "fsl,sec-v4.0"; > + fsl,sec-era = <4>; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x30900000 0x10000>; > + ranges = <0 0x30900000 0x10000>; > + clocks = <&clks IMX7D_CAAM_MEM_CLK>, > + <&clks > IMX7D_CAAM_ACLK_CLK>, > + <&clks IMX7D_CAAM_IPG_CLK>, > + <&clks IMX7D_EIM_ROOT_CLK>; > + clock-names = "mem", "aclk", "ipg", > "emi_slow"; > + > + sec_jr0: jr0@1000 { > + compatible = "fsl,sec-v4.0- > job-ring"; > + reg = <0x1000 0x1000>; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + sec_jr1: jr1@2000 { > + compatible = "fsl,sec-v4.0- > job-ring"; > + reg = <0x2000 0x1000>; > + interrupts = IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + > flexcan1: can@30a00000 { > compatible = "fsl,imx7d-flexcan", > "fsl,imx6q-flexcan"; > reg = <0x30a00000 0x10000>; Looking at the device tree from the NXP kernel [1], the job ring and clock configurations should be slightly different. The job ring configuration has one additional job ring at offset 3000 and interrupt 114. The clock configuration has changed to just one CAAM-specific clock in addition to the ahb clock. This also means that additional modifications to the CAAM driver are necessary or it will complain that it doesn't find all clocks. Thanks, Lukas [1] https://github.com/Freescale/linux-fslc/blob/4.1-2.0.x-imx/arch/arm /boot/dts/imx7d.dtsi