From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227BXc/2/TbCsvqGPYg6EbAEdGKEDBVUjyyxNII6t+c4D+Nfy32EGHc/bBO/u+JXwYldB+Lb ARC-Seal: i=1; a=rsa-sha256; t=1516819034; cv=none; d=google.com; s=arc-20160816; b=VXBcgB3Dr+0iUlU5IaQ2IokXqVhIdbYbTYNWOzg5VeMvoklqydBFNTeA0OaiGL5M27 /xfxayqzq8CXqQdhs6/newU/FExVu5BYhwNnB0sl0vISpOpPCiWRzpCRac+ah95L4UwG ECpCiaBuIfV8wURFHdvn/27ajZ00JnaH2aVelNPOOdrLl+hJPrn2LmM/wkoQtCHZI71K Ylnfddi2RUjC1/dBKxXDjJ4EfjZ5+C0WlJJ7YLWjHFA2qhgwKbIyDJMhT9ipMKbTsRJz dMqWjqG+Pa+YPgm9fEF9b+hdTrJTof53jKYwSHz0RzQc2EgmnMPt/h7CE2T5nU1QCd7s 7/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=QBUhquX1RNgLIQNxuAw+4WbuAWLZppNZN/W8W/gxvV4=; b=vpVoQ0egj0gbviGLxFIPfY3+5MPGOqI6mMhKtK3ohFY8OolIeXEZRHb86MCYFQuYeE 37296V1Z/zHoBfkyrJi8AHw6Tnnp5BVm/z9AcIB/egAJMMfl4kIqP5gB2kX850bbPJjs Na1WNEY48VVsdGjYUhFRVCryiILy9uj2X15TfN8V0+pommqMOF9YgQGwhUsxwkBIKKcc ucodfADAoNuo/wGDkYlzsq2HBsmJT0UdycFUkbBGJfBgN8+z65RrLo7oS+cMiQJey25X xErMf02E55tzFSlZCepswUS+Xw4htteyMhRU2tVwmY4nElBClkslf599G3Qm7Ms4kciI ymUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com From: Vadim Pasternak To: dvhart@infradead.org, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, Vadim Pasternak Subject: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create Date: Wed, 24 Jan 2018 20:33:37 +0000 Message-Id: <1516826019-124903-1-git-send-email-vadimp@mellanox.com> X-Mailer: git-send-email 2.1.4 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500036473711477?= X-GMAIL-MSGID: =?utf-8?q?1590500036473711477?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: The upper layer will manage and report errors returned by the create and destroy functions. FIXME: but it doesn't - we don't even check Signed-off-by: Vadim Pasternak Acked-by: Andy Shevchenko [dvhart: refactored into smaller functional changes] Signed-off-by: Darren Hart (VMware) --- drivers/platform/mellanox/mlxreg-hotplug.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c index e55f576..0ccd327 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -187,16 +187,11 @@ static int mlxreg_hotplug_device_create(struct device *dev, struct mlxreg_hotplug_device *item) { item->adapter = i2c_get_adapter(item->bus); - if (!item->adapter) { - dev_err(dev, "Failed to get adapter for bus %d\n", - item->bus); + if (!item->adapter) return -EFAULT; - } item->client = i2c_new_device(item->adapter, &item->brdinfo); if (!item->client) { - dev_err(dev, "Failed to create client %s at bus %d at addr 0x%02x\n", - item->brdinfo.type, item->bus, item->brdinfo.addr); i2c_put_adapter(item->adapter); item->adapter = NULL; return -EFAULT; -- 2.1.4