From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226aV14LIPftkg3albgPO7Sqm0SI41WXmiliRm8f2UlFXA7YKP6+rznEZ+a3Rgcxe/mRLbRa ARC-Seal: i=1; a=rsa-sha256; t=1516819112; cv=none; d=google.com; s=arc-20160816; b=QLW9YG8o97GRClPb0Qi5tD1EskWgLsorIY2pTr2tdXVvoIFCY6kffpPVBSSU2eSDJ9 YQt5a/N+fGLC7yNlHniqMsFqmGQ8jtSchKcKww4NFD72we+0qEycsWjXTymIL9GAY2rC 2uhWzT2vvZNHoNef2cA/CIXoReXQcdRcPwuvkY6OAKVxG3jMiruj5O6rBnKv4NOkaTLF u+KsZ/1ZEMEX0gnZMDtyV9F3p6Lgt6oVlDqWtl6Od8lH6yuh6SUCyQu9i1hEdbSPSaCH J8I0zl+INxqeNkaL7OQhuLI+SASSCu8SvJY5do/NF2CPtXhwBSjr4URIBvtJBsObRErp xUtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=i+wzb10u8cCfk2hPgsULyIKxGkgBxs6+KT/bWng18Es=; b=D0EeQxRIkgcz6uYpZmnlIvxsBkClT+P+XDkcu8sCYtDmEQTSKsafqOg8sWdx+nvNlt z1aZGwArXVy5EfCgBV02wf8Px8dJi4fMMIfTaO9MZyYyv4uBRr0D1NnuH4nzm0fVE+5x Cg2NZSThU+hRcXSO1cGtIOH6zvWyhiHrC2136DzGdGK84/2eJuAbhS3ESP+Am3LB3HQA TPp3ht4LJHVeCV7JPT9hREF//WDPpgFz+omQZrWouA0GD9nLEMTlC46N3iSjIN17hC04 EjdVyAS7l0jnVjWQhaNh8ruTK+vj7/JcE3Uj+MNlkgFhk6xqaTdZd+YzmGiwD/NA37XI Lhew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com From: Vadim Pasternak To: dvhart@infradead.org, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, Vadim Pasternak Subject: [patch v11 11/12] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value Date: Wed, 24 Jan 2018 20:34:57 +0000 Message-Id: <1516826098-125036-3-git-send-email-vadimp@mellanox.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> References: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500118231102457?= X-GMAIL-MSGID: =?utf-8?q?1590500118231102457?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Verify before creation of hotplug device if the associated adapter number is negative. It could be in case hotplug event is not associated with hotplug device. Signed-off-by: Vadim Pasternak --- drivers/platform/mellanox/mlxreg-hotplug.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c index b891ec7..c806451 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -95,6 +95,14 @@ struct mlxreg_hotplug_priv_data { static int mlxreg_hotplug_device_create(struct mlxreg_core_data *data) { + /* + * Return if adapter number is negative. Return if adapter number is + * negative. It could be in case hotplug event is not associated with + * hotplug device. + */ + if (data->hpdev.nr < 0) + return 0; + data->hpdev.adapter = i2c_get_adapter(data->hpdev.nr); if (!data->hpdev.adapter) return -EFAULT; -- 2.1.4