From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225QZss9z6om4FfGpyWDaJAe1me9SRIepZv/9rsOnzmaPGK059hPK36Fu0EyG4XGLlO8Wj9F ARC-Seal: i=1; a=rsa-sha256; t=1516819113; cv=none; d=google.com; s=arc-20160816; b=P4IP1jcCz4rLgLdhZcYSg3vLqV09+Fb+a/gJ8pnAfJxraOOpBwlSVsawRmjvSbsn79 XWCXpRyADkKxBgsy5d6JfHjllK7Qy1belkyI4iLuYuYn0/O5n3CkW2EoB5cuC3Bk+jfb 0zpYOkMR1i0oRTS9t11Pr42KK07gBX3cmB3zP9iXVzRUe1WhADwX+DKj26b6lgiMeyhj PzAOJEgKCQKEHzEhmnI0J4OuNDmR5epeEuoLFXkkrGya5dMl3cwJblmsOaD04/lcpm1u 3m8T1ncjGtLgvyZm8O95jaIBnEYF7NlpYnNoKU3naDMHqGAG6jLeGj3MaijkpzOcFX4h N4rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Gmb/L9xPeKnnWDjpjhc9remWHcs2mPZ7HC5WSxfKGXc=; b=vjRLPoTV7mQbEruSVQmZopUxObx5kUnCnv5UNn2JDlNiDWGZTeIgPJ7+PPghBhXReE LvehEaDM2F5k35DIBNcPQP0ymmS/T3gLAuGLNX/i4Ib65Gicnf18g724eJz7V7GPFVD2 5sQtZBsdzMhMmtylyv1zzKJc/0SOibNKyz19htCTdv//ZGewYH05vTmBbdN1uwZPNzNQ K+blw9Lk79E+XzCMgNBIlS5nv/lDgMkt9shPiE7JsPl5aSqMpJwnDzFgEJea49FBowo0 E/1qnEOcDhZb6uQ6Ns4v4gdhgB6tbm2pUfDf3FYFPMHkFemT21O0DnIpMZ5GjbUaF7UF 7hOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of vadimp@mellanox.com designates 193.47.165.129 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com From: Vadim Pasternak To: dvhart@infradead.org, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, Vadim Pasternak Subject: [patch v11 12/12] platform/mellanox: Add validation of return code of hotplug device creation routine Date: Wed, 24 Jan 2018 20:34:58 +0000 Message-Id: <1516826098-125036-4-git-send-email-vadimp@mellanox.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> References: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500118317895596?= X-GMAIL-MSGID: =?utf-8?q?1590500118317895596?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Adding validation of return code of mlxreg_hotplug_device_create. It could fail in case the requested adapter is not available or if client can not be connected to the adapter. Error is to be reported in case of bad flow. Signed-off-by: Vadim Pasternak --- drivers/platform/mellanox/mlxreg-hotplug.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c index c806451..e852219 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -263,13 +263,15 @@ mlxreg_hotplug_work_helper(struct mlxreg_hotplug_priv_data *priv, if (item->inversed) mlxreg_hotplug_device_destroy(data); else - mlxreg_hotplug_device_create(data); + ret = mlxreg_hotplug_device_create(data); } else { if (item->inversed) - mlxreg_hotplug_device_create(data); + ret = mlxreg_hotplug_device_create(data); else mlxreg_hotplug_device_destroy(data); } + if (ret) + dev_err(priv->dev, "Failed to create hotplug device.\n"); } /* Acknowledge event. */ @@ -312,8 +314,11 @@ mlxreg_hotplug_health_work_helper(struct mlxreg_hotplug_priv_data *priv, if (regval == MLXREG_HOTPLUG_HEALTH_MASK) { if ((data->health_cntr++ == MLXREG_HOTPLUG_RST_CNTR) || !priv->after_probe) { - mlxreg_hotplug_device_create(data); - data->attached = true; + ret = mlxreg_hotplug_device_create(data); + if (ret) + dev_err(priv->dev, "Failed to create hotplug device.\n"); + else + data->attached = true; } } else { if (data->attached) { -- 2.1.4