From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbeAYKJQ (ORCPT ); Thu, 25 Jan 2018 05:09:16 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:38026 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbeAYKJM (ORCPT ); Thu, 25 Jan 2018 05:09:12 -0500 X-Google-Smtp-Source: AH8x2265OATLOqUWWtROOA1rQU90SAotVLTzXlgXEEH7X5+keeFZv9GIcrLeKa3/Oq2pz89TgDRYZA== From: Jia-Ju Bai To: rjw@rjwysocki.net, lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] acpi: osl: Replace GFP_ATOMIC with GFP_KERNEL in acpi_os_execute Date: Thu, 25 Jan 2018 18:13:41 +0800 Message-Id: <1516875222-12293-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After checking all possible call chains to acpi_os_execute here, my tool finds that acpi_os_execute is never called in atomic context. And acpi_os_execute calls acpi_debugger_create_thread which calls mutex_lock, thus it proves again that acpi_os_execute can call functions which may sleep. Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/acpi/osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 3bb46cb..8ee605e 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -1066,7 +1066,7 @@ acpi_status acpi_os_execute(acpi_execute_type type, * having a static work_struct. */ - dpc = kzalloc(sizeof(struct acpi_os_dpc), GFP_ATOMIC); + dpc = kzalloc(sizeof(struct acpi_os_dpc), GFP_KERNEL); if (!dpc) return AE_NO_MEMORY; -- 1.7.9.5