From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225Gjdw3E2N/wiE6Wz20nnbyg0cfk6kDsXXasSnUlmPGm7rrsqEsPuft5paPLjW813jzUuGy ARC-Seal: i=1; a=rsa-sha256; t=1516882994; cv=none; d=google.com; s=arc-20160816; b=f1N8u7FOxNGzUQ4Q9Q6JMdVIo/yvQBrm2OsbNPREZ8WKiYuErJCTqVJgkURJ1mE2iJ mgETxin3dG3TAltqzF0nJx+UewsJZs6372lqjy5+cZ2PqLeq05wgm4IZRSDPoCRcNqfY uUDblgj0DAUKWLSOZyWTXmkRSSzpdDzM3kR21ty/0VcBdcPFqU3QUC8C4aVTQDXCrexB P28aBAP8u+QSnauHeDNWcY2nkXpaxC3VsMrlpTQMuF3ntmRb/73HlhNQYe3zT4uw03yg 8YejsK3ZSaX6jtEzwnQ9vUfhRTPI2JHTFLtsANAmZLdDIgoIxG0gTv1eemuFLtvNdHhs BctA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=W/ikwOfq4suCvgD3lILmTF3cElXrINxHhSX9WheTfBc=; b=JKl5d26T8Yo2s420qRHogpHWaxffxwWHdSLQ/9fqyWKTJmEwctfbxh9e7tzwQETBKs YybygPkNeowElALKD1CvgxJLgKFFvdEP22rvNtWVcsptnz3FaRSjnGfo/iu5Mj/ghIFx jQk2dVEDm2XezjbAZZyNPtn0arY+0ipetD47XvJzXbG+vYRBHOtvhHA9ckYglByuuHa+ YWGZiqOHaAMtwOFly6c2TYkcP89Z8+f4fLjNhiKSstcAX+BKtSRJ8XnVxli80mL9VELU yHdGWRm2r2gAdnXhfYl09srlOB1ZbaK2CuZSQdjTP2m5l52QRH1f1ERYYyv3uhUXJjmX Oqgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of andriy.shevchenko@linux.intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=andriy.shevchenko@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of andriy.shevchenko@linux.intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,412,1511856000"; d="scan'208";a="24655962" Message-ID: <1516882990.7000.1250.camel@linux.intel.com> Subject: Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI From: Andy Shevchenko To: "Wang, Haiyue" , Greg KH Cc: joel@jms.id.au, arnd@arndb.de, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 25 Jan 2018 14:23:10 +0200 In-Reply-To: References: <1516103552-19601-1-git-send-email-haiyue.wang@linux.intel.com> <20180123084457.GE21463@kroah.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589749751524316291?= X-GMAIL-MSGID: =?utf-8?q?1590567102758740674?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, 2018-01-25 at 10:29 +0800, Wang, Haiyue wrote: > > On 2018-01-23 16:44, Greg KH wrote: > > On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote: > > > + depends on ARCH_ASPEED || COMPILE_TEST > > > + select REGMAP_MMIO > > > > Select or depend? > > Before, I used "depends on". I was told to to change "select". I'm > not > sure which is more better by practice ? git grep will answer to this question, but also documentation is good to read. REGMAP API is selected by users. One case where it's not so looks like a bug. -- Andy Shevchenko Intel Finland Oy