From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516955625; cv=none; d=google.com; s=arc-20160816; b=di9YsZqbuTQi4XO0V7U0uOJUBuGNpWQTFLzUzBi10tj+l6KYhQdM+DFM7UwdZDqSsS QkA+yr8PxIEI1vQbGL6c+MSW4C0Vag+zKNiXyfH0eKdHNU3gVPfPrvFwTwDw/Eaod80b 6wXZg7Fp3Ri5p/2tnhp4JUcVDZR/qX8BzC5j1PqX14YG0RURlRtCU0XWZjqX1B5yucsC 2vsRlB5MmPI0M7Zlw1GXIHk2jsjr5dfIYeBr/dfoFKZS0uHZqpz0rMLN/kRhLt2f8hu3 5O492DB/jgw9KmPr3A1tUssAozDBFGmA3ntsAsl6Hmi2oNKII/u6p3Env551WRzFsrEv Pp1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=TDLIdkgFvJa3NlDPhJALTk7wD7IrDcL6feNo7sXr5l4=; b=oDrGOhA1om5kB4Rv3JJwEoAQbRX6PmkSvogzOFx9pGBfgJePtkoGP9qNQh9E7N+MZl 8YeWp73yuCqy4rFfc9/FSHuSfZ+pyN5iYdVZAoPxHu+AfUqbgM9I81g3nF12Eww83/Bo ra67y9luUpAgmhE9wiXEyeFyg9LnNQJXPHP2zbdyyO+G2eYfxGunrYJF1zFFRgWpDR5j yazooakJG0b6Wnlv9or0RbPmEQMs1hbl/5GOweFqoY3RyFp3oZy19vTDV89kA5NtBYuO p0TMRAGQP/S5wGj3xoOFAWXy+KJKCHYA8XNt17O39sBDrXzVBEj0BoPpVwhSItiHd4SF vUuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PmoyJvMR; spf=pass (google.com: domain of baijiaju1990@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=baijiaju1990@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PmoyJvMR; spf=pass (google.com: domain of baijiaju1990@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=baijiaju1990@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com X-Google-Smtp-Source: AH8x22682tbgnQ/IM7ap44eMG5RPQ0tj+2m8qX/RElRoqfkPm/jjcNedMLws8EIIyZ283oPX4/VlUg== From: Jia-Ju Bai To: rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org, len.brown@intel.com, pavel@ucw.cz, gregkh@linuxfoundation.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] base: power: domain: Replace mdelay with msleep Date: Fri, 26 Jan 2018 16:38:19 +0800 Message-Id: <1516955899-31810-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590643262439305991?= X-GMAIL-MSGID: =?utf-8?q?1590643262439305991?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: After checking all possible call chains to genpd_dev_pm_detach() and genpd_dev_pm_attach() here, my tool finds that these functions are never called in atomic context, namely never in an interrupt handler or holding a spinlock. Thus mdelay can be replaced with msleep to avoid busy wait. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/base/power/domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 0c80bea..f84ac72 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2144,7 +2144,7 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off) if (ret != -EAGAIN) break; - mdelay(i); + msleep(i); cond_resched(); } @@ -2231,7 +2231,7 @@ int genpd_dev_pm_attach(struct device *dev) if (ret != -EAGAIN) break; - mdelay(i); + msleep(i); cond_resched(); } mutex_unlock(&gpd_list_lock); -- 1.7.9.5