From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751478AbeAZQuG (ORCPT ); Fri, 26 Jan 2018 11:50:06 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:42074 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbeAZQuF (ORCPT ); Fri, 26 Jan 2018 11:50:05 -0500 X-Google-Smtp-Source: AH8x225IRpZfmY+ljPg7KyyHkKbdR0Ngydnd/7g09roQ8zTH0pklDsl62ykB63OMNKYla4enJnnxYQ== From: Jia-Ju Bai To: bernhard.walle@gmx.de Cc: linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] firmware: memmap: Replace GFP_ATOMIC with GFP_KERNEL in firmware_map_add_hotplug Date: Sat, 27 Jan 2018 00:54:40 +0800 Message-Id: <1516985680-9575-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After checking all possible call chains to firmware_map_add_hotplug(), my tool finds that this function is never called in atomic context, namely never in an interrupt handler or holding a spinlock. I manually check the code, and find that this function is only called by add_memory_resource() that calls mem_hotplug_begin(), and mem_hotplug_begin() calls mutex_lock() that can sleep, so it indicates that firmware_map_add_hotplug() can call function which can sleep. Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. And I also manually audit the result. Signed-off-by: Jia-Ju Bai --- drivers/firmware/memmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c index 5de3ed2..598eb05 100644 --- a/drivers/firmware/memmap.c +++ b/drivers/firmware/memmap.c @@ -297,7 +297,7 @@ int __meminit firmware_map_add_hotplug(u64 start, u64 end, const char *type) entry = firmware_map_find_entry_bootmem(start, end - 1, type); if (!entry) { - entry = kzalloc(sizeof(struct firmware_map_entry), GFP_ATOMIC); + entry = kzalloc(sizeof(struct firmware_map_entry), GFP_KERNEL); if (!entry) return -ENOMEM; } else { -- 1.7.9.5