From: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
To: Bryan O'Donoghue <bod@kernel.org>,
Bryan O'Donoghue <bod.linux@nxsw.ie>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node
Date: Wed, 8 Oct 2025 23:33:17 +0530 [thread overview]
Message-ID: <1516f21e-aee3-42cf-b75e-61142dc9578d@oss.qualcomm.com> (raw)
In-Reply-To: <4cb4a92d-2f20-47c7-881e-aadcc6f83aa0@kernel.org>
On 10/7/2025 8:14 PM, Bryan O'Donoghue wrote:
> On 07/10/2025 15:29, Bryan O'Donoghue wrote:
>> On 07/10/2025 15:25, Bryan O'Donoghue wrote:
>>> Rob suggested using an implicit index for function id
>>>
>>> https://lore.kernel.org/all/CAL_JsqK9waZK=i+ov0jV-
>>> PonWSfddwHvE94Q+pks4zAEtKc+yg@mail.gmail.com/
>>>
>>> Couldn't we list the entire set of iommus - then detach - subsequently
>>> re-attaching in our platform code with FUNCTION_IDs we keep listed in
>>> our drivers ?
>>>
TMK, there is no api exist to detach a device once it is attached to
smmu. We used to have one but removed[1], not sure how well it will be
received to introduce it again.
There is other problem exist attaching the entire set of iommus in the
first place: Usually writes to SMR registers are protected through
emulation by hyp. Thus adding the sids of protected/non-protected
usecases in the same iommu set will not allowed by the
hypervisors(eg:gunyah), as all will end up in using the same context
bank, thus there can be failure to attach to smmu in the first place.
[1]
https://lore.kernel.org/all/20230110025408.667767-1-baolu.lu@linux.intel.com/
>>> That way the DT is complete and correct, we have a compliant upstream DT
>>> but we also find a way to make the FUNCTION_ID specific setup we need.
>>
>> i.e. you can keep the FUNCTION_ID "metadata" in the driver and
>> associate specific iommu indexes with the FUNCTION_ID you want in there.
>>
>> That way you could have multiple FUNCTION_ID smmu entries in the DT
>> and just associate the DT indexes locally in drivers/platform/qcom/
>> iris_metadata_goes_here.c
>>
>> ---
>> bod
>
> Actually why can't we specify FUNCTION_ID in the iommus = <entries>
>
> Surely we could do
>
> #iommu-cells = <4>;
> iommus = <&apps_smmu 0x420 0x2 FUNCTION_ID>;
>
> and encode the real data we need directly in the iommus list...
>
Since it is the smmu device property , this suggestion expects all the
devices, not just video, to define additional argument. Does this look
valid?
> ---
> bod
next prev parent reply other threads:[~2025-10-08 18:03 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 15:48 Vikash Garodia
2025-06-27 15:48 ` [PATCH v3 1/5] media: dt-bindings: add non-pixel property in iris schema Vikash Garodia
2025-06-27 16:31 ` Bryan O'Donoghue
2025-06-27 17:16 ` Vikash Garodia
2025-06-30 15:48 ` neil.armstrong
2025-06-30 15:56 ` Neil Armstrong
2025-07-02 11:13 ` Krzysztof Kozlowski
2025-07-02 11:32 ` Vikash Garodia
2025-07-02 11:46 ` Krzysztof Kozlowski
2025-07-02 13:11 ` Konrad Dybcio
2025-07-02 13:59 ` Krzysztof Kozlowski
2025-07-02 16:36 ` Vikash Garodia
2025-07-02 20:16 ` Krzysztof Kozlowski
2025-07-03 10:11 ` Konrad Dybcio
2025-07-03 7:29 ` Krzysztof Kozlowski
2025-07-02 11:23 ` Krzysztof Kozlowski
2025-07-02 11:45 ` Vikash Garodia
2025-07-02 11:47 ` Krzysztof Kozlowski
2025-07-02 11:55 ` Vikash Garodia
2025-07-02 11:58 ` Krzysztof Kozlowski
2025-07-02 12:08 ` Vikash Garodia
2025-07-02 12:11 ` Krzysztof Kozlowski
2025-06-27 15:48 ` [PATCH v3 2/5] media: iris: register and configure non-pixel node as platform device Vikash Garodia
2025-06-27 17:01 ` Bryan O'Donoghue
2025-07-02 11:04 ` Krzysztof Kozlowski
2025-07-02 11:39 ` Vikash Garodia
2025-07-02 12:45 ` Konrad Dybcio
2025-06-27 15:48 ` [PATCH v3 3/5] media: iris: use np_dev as preferred DMA device in HFI queue management Vikash Garodia
2025-06-27 17:03 ` Bryan O'Donoghue
2025-06-27 15:48 ` [PATCH v3 4/5] media: iris: select appropriate DMA device for internal buffers Vikash Garodia
2025-06-27 17:07 ` Bryan O'Donoghue
2025-06-27 15:48 ` [PATCH v3 5/5] media: iris: configure DMA device for vb2 queue on OUTPUT plane Vikash Garodia
2025-06-27 17:08 ` Bryan O'Donoghue
2025-06-30 7:58 ` Vikash Garodia
2025-07-01 12:04 ` Konrad Dybcio
2025-06-27 16:30 ` [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node Bryan O'Donoghue
2025-06-27 17:00 ` Vikash Garodia
2025-07-02 11:05 ` Krzysztof Kozlowski
2025-06-30 15:55 ` neil.armstrong
2025-06-30 18:04 ` neil.armstrong
2025-07-01 8:42 ` Konrad Dybcio
2025-07-01 10:23 ` Vikash Garodia
2025-07-01 13:19 ` Neil Armstrong
2025-07-01 16:11 ` Vikash Garodia
2025-07-02 7:59 ` Neil Armstrong
2025-07-02 11:06 ` Krzysztof Kozlowski
2025-07-02 11:18 ` Krzysztof Kozlowski
2025-07-02 11:37 ` Vikash Garodia
2025-07-02 11:52 ` Krzysztof Kozlowski
2025-07-02 11:54 ` Krzysztof Kozlowski
2025-07-02 12:01 ` Vikash Garodia
2025-07-02 12:05 ` Krzysztof Kozlowski
2025-07-02 12:57 ` Vikash Garodia
2025-07-02 12:06 ` Bryan O'Donoghue
2025-07-02 22:26 ` Dmitry Baryshkov
2025-07-03 7:27 ` Krzysztof Kozlowski
2025-07-03 12:38 ` Konrad Dybcio
2025-07-03 12:54 ` Krzysztof Kozlowski
2025-07-03 15:28 ` Konrad Dybcio
2025-07-03 20:28 ` Bryan O'Donoghue
2025-07-03 21:23 ` Dmitry Baryshkov
2025-07-04 8:23 ` Bryan O'Donoghue
2025-07-04 10:28 ` Konrad Dybcio
2025-07-04 16:45 ` Dmitry Baryshkov
2025-07-04 22:44 ` Bryan O'Donoghue
2025-07-10 18:18 ` Prakash Gupta
2025-07-15 12:15 ` Konrad Dybcio
2025-10-07 14:11 ` Charan Teja Kalla
2025-10-07 14:25 ` Bryan O'Donoghue
2025-10-07 14:29 ` Bryan O'Donoghue
2025-10-07 14:44 ` Bryan O'Donoghue
2025-10-07 19:40 ` Dmitry Baryshkov
2025-10-07 22:10 ` Bryan O'Donoghue
2025-10-08 3:10 ` Dmitry Baryshkov
2025-10-08 3:13 ` Dmitry Baryshkov
2025-10-08 18:03 ` Charan Teja Kalla [this message]
2025-10-09 0:10 ` Bryan O'Donoghue
2025-10-09 0:32 ` Krzysztof Kozlowski
2025-10-09 0:43 ` Bryan O'Donoghue
2025-10-09 0:47 ` Krzysztof Kozlowski
2025-10-09 0:55 ` Bryan O'Donoghue
2025-10-09 1:04 ` Krzysztof Kozlowski
2025-10-09 2:52 ` Vikash Garodia
2025-10-09 2:55 ` Krzysztof Kozlowski
2025-10-09 8:38 ` Bryan O'Donoghue
2025-10-09 9:11 ` Krzysztof Kozlowski
2025-10-09 10:40 ` Vikash Garodia
2025-10-09 10:45 ` Krzysztof Kozlowski
2025-10-09 11:06 ` Bryan O'Donoghue
2025-10-09 13:59 ` Krzysztof Kozlowski
2025-10-09 5:23 ` Charan Teja Kalla
2025-10-09 8:14 ` Krzysztof Kozlowski
2025-10-09 12:36 ` Konrad Dybcio
2025-07-04 19:15 ` Vikash Garodia
2025-10-08 3:11 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516f21e-aee3-42cf-b75e-61142dc9578d@oss.qualcomm.com \
--to=charan.kalla@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod.linux@nxsw.ie \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®