From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1517117106; cv=none; d=google.com; s=arc-20160816; b=JV5BLpWwyi9Azjna5Se9UGi5edkV0wge6ekOiKyBqzvCeWANSlT6V7UQU7xVJSLnoA gEEzxGCELtS/IzdLTlLmWajpJY2PKej/sgTl3blSrav4B+Tlavcei/y09kRXCzRGgn9e HYJYYhtvxiSasUY2x9+PuZgI7hvPzLtjlYSQTL98Uw/6z9Y1hcdFhmAGmB1xnRVXmLo3 o97H2fIgRix4vuFmPqQFQfrr5pJ3lrdJy6w3zm1IwxLFYp6//d5ek3d6l/g6CCmfKl1l Zq+kJUxuP0rif7YgYUH6CfoHGs8hnHzg89n7L2tnH112DPeNJDGS0SdnK4UUFxiLLjXf yzsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=p7EezD6SqV/X16P9f+a270gbpClqI7dLgIRLdB/ykyA=; b=GB6pbAlWLY48t64Jb3tb+MAQ+zRlCE0pw7PMmEqv56evnLmyDEL+UhKc95pvpi1qk3 qKwVO/ICZhc4881UjvyG+MIY/Hv3mjDR3Py8MU6BhwRDDMFWGFuZsjWYA9o/s/Xoal53 lijQgL6pbb2EvOJZ8WCB+/F1RfsP4rGF9ZJCG64itGvO4X/m87vK2aHWUJ3SvWJck8iu 9iVujSeXzCDHkurSmt7k4CuBQPp+iV6q/+cm/DMl9NmYgHEl23oQiQDdtKBqH7VLAzNk hcislPfzxW0XxANPyy9u1azxoajAQ4lQT7oV1IBrxsJvS+pcxDQk73BWshi7inK6XgBA xGgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YNDcJJ5O; spf=pass (google.com: domain of pundirsumit11@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=pundirsumit11@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YNDcJJ5O; spf=pass (google.com: domain of pundirsumit11@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=pundirsumit11@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com X-Google-Smtp-Source: AH8x225uwMNYHb8ZPGKgGtUHsPquxWFoVwkW46X5BeE5lHcucey/ulLh5jrea1ulwhg+lX1AXXs2yQ== From: Sumit Pundir To: oleg.drokin@intel.com Cc: andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: lustre: lnet: return of an error code should be negative Date: Sun, 28 Jan 2018 10:54:55 +0530 Message-Id: <1517117095-12643-1-git-send-email-pundirsumit11@gmail.com> X-Mailer: git-send-email 2.7.4 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590812586832482229?= X-GMAIL-MSGID: =?utf-8?q?1590812586832482229?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Return value of error codes should typically be negative. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir Reviewed-by: Andreas Dilger Reviewed-by: James Simmons --- drivers/staging/lustre/lnet/selftest/framework.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c index c7697f6..0ca1e3a 100644 --- a/drivers/staging/lustre/lnet/selftest/framework.c +++ b/drivers/staging/lustre/lnet/selftest/framework.c @@ -187,7 +187,7 @@ sfw_del_session_timer(void) return 0; } - return EBUSY; /* racing with sfw_session_expired() */ + return -EBUSY; /* racing with sfw_session_expired() */ } static void -- 2.7.4