From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751464AbeA2Elt convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Sun, 28 Jan 2018 23:41:49 -0500
Received: from mout.gmx.net ([212.227.17.22]:52994 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751127AbeA2Elr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 28 Jan 2018 23:41:47 -0500
Message-ID: <1517200880.10151.15.camel@gmx.de>
Subject: Re: [RFC PATCH V5 5/5] workqueue: introduce a way to set
 workqueue's scheduler
From: Mike Galbraith <efault@gmx.de>
To: Lai Jiangshan <jiangshanlai@gmail.com>,
        Wen Yang <wen.yang99@zte.com.cn>
Cc: Tejun Heo <tj@kernel.org>, zhong.weidong@zte.com.cn,
        Jiang Biao <jiang.biao2@zte.com.cn>, Tan Hu <tan.hu@zte.com.cn>,
        kernel test robot <xiaolong.ye@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Date: Mon, 29 Jan 2018 05:41:20 +0100
In-Reply-To: <CAJhGHyACFahA2k0cX+=SngjfOV_uvCrTBbkWpGsRX4X5CGeZxQ@mail.gmail.com>
References: <1517030127-21391-1-git-send-email-wen.yang99@zte.com.cn>
         <1517030127-21391-5-git-send-email-wen.yang99@zte.com.cn>
         <CAJhGHyACFahA2k0cX+=SngjfOV_uvCrTBbkWpGsRX4X5CGeZxQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
X-Provags-ID: V03:K0:NGhR+/xargcay/6dMSjr/X+Q3LwM+pw5NRAZIavTPgZv5wf98WT
 kN29GgFDac+0kUPtObWDqHAqN9eaYwlSMsvlWjgb1gqFIQaXJ8JK40NsIyxiludYbbcqQz2
 qfcqpmgA/8qKLGEEJKHmng2BDvCsQgH+igFXiqoOWgcWylIHqkhOVM/vhZjo4VoOi6wOSpd
 r/AFXNcZ8YSCK4foUVw1w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:gmeQfJlYWk4=:DpfAi9N9zehUzBqksJdBQF
 EnTX6K6je0/CWH8L/WcGkmPHN5f26EN9tWSUnIqvww2+oNxBuD4BIfc3pPTsv3aE4G9XOjtTI
 FmrBz0ObIS7lh45SiWdDPtPr9QeP1/qlbOumxqecSCAVx+ihvrWGfcSali5qIzMdzGLfKg21u
 UcAeO2VaF5U8ZccK4Xj2A1BRjLygQXOQvYHacBqdtmOFS8NMOtq2eowvD4HZLYUmuDkyUYQUq
 k8zr8KPzPekXZZLu6iYDJrxknvsKN8UTuqZG+LUFfZic3J1owSA877okrKheR2TLAjrSMJ3lX
 VSrjcoew71eQGBl56dO8SqwZ6X36OX653OEUZfo5JYY3wH8i4etAxH2BlM6DsEmmTEoJOzizU
 n/VaqfhstIufbwQhZb8QTsJ+hcPYQDi7fYhYlPpgfgKAYhQT2OZHfptkXMs5Ty9ZTXgs5LZNc
 +aoflbx8kOKjrnUI4cjaXZjZ1yILw9g3QSPq3q0W8Vtbmrp+XXu105FZ8Szo0HaPo8bm/VKpc
 uJbbec5XmlUCC+nRIGgIIWp7rN/pK9wrSQWJX9uEwRy0Jpg+8VeXRfSYsTIspECDa/B5C88m/
 dxedJD5Yd2HoC8tPhJtbqSKeU7jBM3N/O1XW1UF1WPYj8zTnrFTY5mVL7jzcGIopHmRIHkseX
 WH32Nf7YhWohgWym6w2akZHtAM+XoDpQqXTMKozTH1CIDYrgQuBynZHqkX0z2l1Dx4D3/QaLF
 uozl/0TU4YzD87c1Yd2nOP4+SmCLmTkJahgAi1+DojJW1o2ydDurnAtTyzVqg0PixJDJNZA2q
 hkvD4xjv4cwd7/7GgsRjQiMfmJzHUj/hCLaW67JZu3Xt57hTnM=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2018-01-29 at 12:15 +0800, Lai Jiangshan wrote:
> I think adding priority boost to workqueue(flush_work()) is the best
> way to fix the problem.

I disagree, priority boosting is needlessly invasive, takes control out
of user hands.  The kernel wanting to run a workqueue does not justify
perturbing the user's critical task.

I think "give userspace rope" is always the best option, how rope is
used is none of our business.  Giving the user a means to draw a simple
line in the sand, above which they run only critical stuff, below
which, they can do whatever they want, sane in our opinions or not,
lets users do whatever craziness they want/need to do, and puts the
responsibility for consequences squarely on the right set of shoulders.

	-Mike