From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbeA2G0h convert rfc822-to-8bit (ORCPT ); Mon, 29 Jan 2018 01:26:37 -0500 Received: from mx01.hxt-semitech.com.96.203.223.in-addr.arpa ([223.203.96.7]:44613 "EHLO barracuda.hxt-semitech.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751032AbeA2G0g (ORCPT ); Mon, 29 Jan 2018 01:26:36 -0500 X-ASG-Debug-ID: 1517207191-093b7e430537360001-xx1T2L X-Barracuda-Envelope-From: shunyong.yang@hxt-semitech.com From: "Yang, Shunyong" To: "vinod.koul@intel.com" CC: "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values Thread-Topic: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values X-ASG-Orig-Subj: Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values Thread-Index: AQHTmMofrqgtNukibE2Ncot9+9gZyA== Date: Mon, 29 Jan 2018 06:26:40 +0000 Message-ID: <1517207190.2845.6.camel@hxt-semitech.com> References: <1516617881-30044-1-git-send-email-shunyong.yang@hxt-semitech.com> <20180129044801.GL18649@localhost> In-Reply-To: <20180129044801.GL18649@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.64.6.3] Content-Type: text/plain; charset="iso-8859-15" Content-ID: <373598F47E9F4E4BBB35C15FEFAA8160@hxt-semitech.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Barracuda-Connect: localhost[10.128.0.15] X-Barracuda-Start-Time: 1517207191 X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA X-Barracuda-URL: https://192.168.50.101:443/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.4825 1.0000 0.0000 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.47360 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Vinod On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote: > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote: > > > > Current coding style prefers octal permissions values. This patch > > changes symbolic permissions to octal values. > Is this preference documented anywhere? > When using symbolic permissions like "S_IRUGO | S_IWUSR". The checkpatch.pl will output some warnings to suggest to use octal values. I quote following lines from checkpatch.pl, # check for uses of S_ that could be octal for readability ... if (WARN("SYMBOLIC_PERMS",                                  "Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'.\n" . $herecurr) &&                             $fix) {                                 $fixed[$fixlinenr] =~ s/$val/$octal/;                         } Thanks. Shunyong