From: David Woodhouse <dwmw2@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>, Filippo Sironi <sironi@amazon.de>
Cc: tglx@linutronix.de, KarimAllah Raslan <karahmed@amazon.de>,
x86@kernel.org, KVM list <kvm@vger.kernel.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
bp@alien8.de, peterz@infradead.org
Subject: Re: [PATCH] KVM: x86: Reduce retpoline performance impact in slot_handle_level_range()
Date: Fri, 02 Feb 2018 21:14:02 +0000 [thread overview]
Message-ID: <1517606042.31953.78.camel@infradead.org> (raw)
In-Reply-To: <1006017023.5326022.1517605836751.JavaMail.zimbra@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Fri, 2018-02-02 at 16:10 -0500, Paolo Bonzini wrote:
> > > On 2. Feb 2018, at 15:59, David Woodhouse <dwmw@amazon.co.uk> wrote:
> > > With retpoline, tight loops of "call this function for every XXX" are
> > > very much pessimised by taking a prediction miss *every* time.
> > >
> > > This one showed up very high in our early testing, and it only has five
> > > things it'll ever call so make it take an 'op' enum instead of a
> > > function pointer and let's see how that works out...
> > >
> > > Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
>
> What about __always_inline instead?
Yeah, Linus suggested that and it looks like it generates sane (in fact
better) code. Will do some more testing and send it out for real
probably on Monday. Thanks.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
next prev parent reply other threads:[~2018-02-02 21:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 14:59 David Woodhouse
2018-02-02 15:43 ` Sironi, Filippo
2018-02-02 21:10 ` Paolo Bonzini
2018-02-02 21:14 ` David Woodhouse [this message]
2018-02-02 18:50 ` Linus Torvalds
2018-02-02 19:10 ` Linus Torvalds
2018-02-02 19:17 ` David Woodhouse
2018-02-02 21:23 ` Alan Cox
2018-02-03 14:46 ` David Woodhouse
2018-02-05 8:51 ` Peter Zijlstra
2018-02-05 8:55 ` Peter Zijlstra
2018-02-05 15:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517606042.31953.78.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=bp@alien8.de \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sironi@amazon.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®