From: David Woodhouse <david@woodhou.se>
To: Guenter Roeck <linux@roeck-us.net>, Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
gnomes@lxorguk.ukuu.org.uk, Rik van Riel <riel@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
thomas.lendacky@amd.com, Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jiri Kosina <jikos@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Dave Hansen <dave.hansen@intel.com>,
Kees Cook <keescook@google.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linux-foundation.org>,
Paul Turner <pjt@google.com>
Subject: Re: [RFC] x86/retpoline: Add clang support for 64-bit builds
Date: Tue, 06 Feb 2018 20:52:21 +0000 [thread overview]
Message-ID: <1517950341.3677.27.camel@woodhou.se> (raw)
In-Reply-To: <20180206203218.GA11026@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Tue, 2018-02-06 at 12:32 -0800, Guenter Roeck wrote:
>
> >
> Feedback, anyone ?
>
> I understand that there is no love for the ABI differences between clang
> and gcc, but that doesn't help me. Even if the patch is unacceptable
> as-is, I would like to have some feedback to get an idea if I am on the
> right track, and what I would have to change to at least move into the
> right direction.
I'm going for just a comprehensive NACK. If they fix clang so that at
least the thunk symbols __x86_indirect_thunk_\reg are compatible, then
we could tolerate command line differences. Otherwise, just no.
Unless you really fancy trying to do some kind of alias hack in modules
so that they link to the external thunk by its proper name, even when
built with clang? I reserve the right to hate that too.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5206 bytes --]
next prev parent reply other threads:[~2018-02-06 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 23:30 Guenter Roeck
2018-02-06 20:32 ` Guenter Roeck
2018-02-06 20:52 ` David Woodhouse [this message]
2018-02-06 21:01 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517950341.3677.27.camel@woodhou.se \
--to=david@woodhou.se \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®