From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 06/12] parport: Convert to use managed functions pcim_* and devm_*
Date: Wed, 7 Feb 2018 19:47:53 +0000 [thread overview]
Message-ID: <1518032879-5844-6-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1518032879-5844-1-git-send-email-sudipm.mukherjee@gmail.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller an tidier.
Tested-by: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
drivers/parport/parport_serial.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/parport/parport_serial.c b/drivers/parport/parport_serial.c
index d0a5bc5..050eeb0 100644
--- a/drivers/parport/parport_serial.c
+++ b/drivers/parport/parport_serial.c
@@ -620,27 +620,23 @@ static int parport_serial_pci_probe(struct pci_dev *dev,
struct parport_serial_private *priv;
int err;
- priv = kzalloc (sizeof *priv, GFP_KERNEL);
+ priv = devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
+
pci_set_drvdata (dev, priv);
- err = pci_enable_device (dev);
- if (err) {
- kfree (priv);
+ err = pcim_enable_device(dev);
+ if (err)
return err;
- }
- if (parport_register (dev, id)) {
- kfree (priv);
+ if (parport_register(dev, id))
return -ENODEV;
- }
if (serial_register (dev, id)) {
int i;
for (i = 0; i < priv->num_par; i++)
parport_pc_unregister_port (priv->port[i]);
- kfree (priv);
return -ENODEV;
}
@@ -660,7 +656,6 @@ static void parport_serial_pci_remove(struct pci_dev *dev)
for (i = 0; i < priv->num_par; i++)
parport_pc_unregister_port (priv->port[i]);
- kfree (priv);
return;
}
--
2.7.4
next prev parent reply other threads:[~2018-02-07 19:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 19:47 [PATCH 01/12] parport: ax88796: Delete an error message for a failed memory allocation in parport_ax88796_probe() Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 02/12] parport: ax88796: Improve a size determination " Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 03/12] parport: ax88796: Delete an unnecessary variable initialisation " Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 04/12] parport: Add support for BrainBoxes PX272/PX306 MIO card Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 05/12] parport: PCI core handles power state for us Sudip Mukherjee
2018-02-07 19:47 ` Sudip Mukherjee [this message]
2018-02-07 19:47 ` [PATCH 07/12] parport: Don't shadow error codes in ->probe() Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 08/12] parport: Convert printk(KERN_WARN) to dev_warn() Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 09/12] parport: Switch to use module_pci_driver() macro Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 10/12] parport: Sort headers alphabetically Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 11/12] parport: Replace short License header by SPDX identifier Sudip Mukherjee
2018-02-07 19:47 ` [PATCH 12/12] parport_pc: Add support for WCH CH382L PCI-E single parallel port card Sudip Mukherjee
2018-03-01 10:46 ` [PATCH 01/12] parport: ax88796: Delete an error message for a failed memory allocation in parport_ax88796_probe() Andy Shevchenko
2018-03-01 12:06 ` Greg Kroah-Hartman
2018-03-01 12:17 ` Andy Shevchenko
2018-03-03 21:00 ` Sudip Mukherjee
2018-03-12 14:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518032879-5844-6-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®